1584109 - Add graphics telemetry metrics for geckoview streaming

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Jamie Nicol [:jnicol]]

Bug 1580129 was used only to add COMPOSITE_TIME in the end, so this bug will now be used for adding the remaining graphics metrics

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: data_review.md

Data review request for adding more graphics related probes to geckoview_streaming (from list in bug 1568589).

Comment 2

[Jamie Nicol [:jnicol]]

Attachment: Bug 1584109 - Rename WR_RENDER_TIME to WR_FRAMEBUILD_TIME. r?jrmuizel

It is actually measuring frame building time, not rendering.

Comment 3

[Jamie Nicol [:jnicol]]

Attachment: Bug 1584109 - Add graphics telemetry probes to geckoview_streaming. r?jrmuizel,dexter

Depends on D48343

Comment 4

[Chris H-C :chutten]

Comment on attachment 9099200 [details]
data_review.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is both Telemetry and Glean so is documented in its definitions files [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and [metrics.yaml](https://hg.mozilla.org/mozilla-central/raw-file/tip/toolkit/components/telemetry/geckoview/streaming/metrics.yaml), in addition to the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/) and in the [Glean auto-generated docs in engine-gecko-nightly](https://github.com/mozilla-mobile/android-components/blob/master/components/browser/engine-gecko-nightly/docs/metrics.md).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Glean so can be controlled through Fenix's Data Collection Settings.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Jamie Nicol is responsible for this overall collection. The smaller datapoints within have different responsible persons documented in the Glean [metrics.yaml](https://hg.mozilla.org/mozilla-central/raw-file/tip/toolkit/components/telemetry/geckoview/streaming/metrics.yaml).

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Some are default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff2294f51756
Rename WR_RENDER_TIME to WR_FRAMEBUILD_TIME. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/cbf48b3db921
Add graphics telemetry probes to geckoview_streaming. r=jrmuizel,Dexter

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ff2294f51756
https://hg.mozilla.org/mozilla-central/rev/cbf48b3db921