Closed Bug 1584183 Opened 7 months ago Closed 6 months ago

nsILoadInfo.requestBlockingReason not set for all classification results

Categories

(Toolkit :: Safe Browsing, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently nsILoadInfo.requestBlockingReason is set in nsChannelClassifier::OnClassifyComplete but a better place is UrlClassifierCommon::SetBlockedContent. This will automatically assign the reason also for few new error codes (added with the patch).

Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Priority: -- → P2
Pushed by honzab.moz@firemni.cz:
https://hg.mozilla.org/integration/autoland/rev/0cd4794603af
Set nsILoadInfo.requestBlockingReason in UrlClassifierCommon::SetBlockedContent, r=dimi
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.