1584187 - Perma bustage on builds/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp when Gecko 71 merges to Beta on 2019-10-14

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Dorel Luca [:dluca]]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

Central as beta:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ea784bd9704dd065a89f92cdd58bb43b0cb8283f&selectedJob=268544655

Failure log:
https://treeherder.mozilla.org/logviewer.html#?job_id=268544655&repo=try

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[task 2019-09-26T11:34:40.788Z] 11:34:40 ERROR - /builds/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:5706:15: error: unused variable 'disp' [-Werror,-Wunused-variable]
[task 2019-09-26T11:34:40.788Z] 11:34:40 INFO - const auto* disp = computedStyle->StyleDisplay();

Comment 2

[Daniel Holbert [:dholbert]]

Thanks for the heads-up.

I've got a trivial patch (with mozilla::Unused). Just testing locally and then I'll post.

Comment 3

[Daniel Holbert [:dholbert]]

The patch is at https://phabricator.services.mozilla.com/D47319 , though it's stuck in a draft state right now (which is why it hasn't appeared on the bug yet), due to some temporary phabricator issues.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: Bug 1584187: Pass an assertion-only variable to mozilla::Unused, to fix non-nightly opt build error. r?mats

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70ff507dae3b
Pass an assertion-only variable to mozilla::Unused, to fix non-nightly opt build error. r=mats

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/70ff507dae3b