1584252 - Add a single-window implementation of the windows API

Status: NEW

(GeckoView :: Extensions, enhancement, P3)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

As far as I am aware, there are a few bits within WebExtensions that depends on the windows API. It seems GeckoView already has the windowTracker, so most of the work is likely already done. To finish this off, I feel GeckoView should expose a windows API that provides access to that single window that is available, and throws on attempting to create new windows.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Mass moving bugs to the Extension component.

Comment 2

[Chris Peterson [:cpeterson]]

Agi says we probably already have this API. He will confirm.

Comment 3

[Chris Peterson [:cpeterson]]

P3, not P1 because this bug isn't blocking anything right now.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

We don't need this for ad blocks but it might be useful to do in general for compatibility with desktop.

Comment 7

[Chris Peterson [:cpeterson]]

Tasks and enhancements should have severity N/A.

Comment 8

[juraj.masiar]

I've noticed that currently each tab in Android has a different windowId (and they all have index: 0, so separate windows?).
When this is implemented, they will all share the same windowId, right?

Interestingly though, the way it is implemented now, it allows one to create a simple polyfill for the missing browser.window API:
https://gist.github.com/Juraj-Masiar/cadb8fa0a8f556a0ad06aa3e588a7bfc

Comment 9

[Rob Wu [:robwu]]

(In reply to juraj.masiar from comment #8)

I've noticed that currently each tab in Android has a different windowId (and they all have index: 0, so separate windows?).

This is the current implementation, but not necessarily a desired end-state in the API. The one-tab-per-window implementation prevents the implementation of tabs.move, for example.