1584283 - Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P5)

Description

[Brian Grinstead [:bgrins]]

+++ This bug was initially created as a clone of Bug #1583377 +++

Similar to xul:page, I'd like to stop using non-window xul root elements in order to make migration to html roots easier.

There are only two consumers of this element in m-c: https://searchfox.org/mozilla-central/search?q=%3Cwizard&path=.

• There are two places in the platform that treat wizard specially https://searchfox.org/mozilla-central/search?q=%3A%3Awizard&path=. One is just because it's a root element, and the other is an accessible place that I believe can be fixed by using [role=dialog] on the new root: https://searchfox.org/mozilla-central/rev/f1e99da78fe6c3c68696358dac06aed90f8112d3/accessible/generic/RootAccessible.cpp#89.
• There are also hits in JS such as document.documentElement.rewind, document.documentElement.cancel, etc (https://searchfox.org/mozilla-central/rev/f1e99da78fe6c3c68696358dac06aed90f8112d3/toolkit/content/widgets/wizard.js#472) which depend on the documentElement being the <wizard> custom element with these properties. Those calls should be able to switch to this within the wizard CE and to a reference to the DOM node from any external callers (if any).
• Some of the CSS (when it's treating wizard as a root element) can be removed as well: https://searchfox.org/mozilla-central/search?q=%5Ewizard&regexp=true&path=.css.

Comment 1

[Robin Steuber (they/them) [:bytesized]]

Attachment: Bug 1584283 - Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child r=bgrins,surkov

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01007f3333ea
Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child r=surkov

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 01007f3333ea (bug 1584283) for Browser-chrome failures in widget/tests/browser/browser_test_procinfo.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272491127&repo=autoland&lineNumber=926

Backout:
https://hg.mozilla.org/integration/autoland/rev/e9eb4eef6826b6834378edbcc7fd40747c6fc388

The failures didn't actually started with this push, hence it was relaned and NI was canceled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59f238b4844f
Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child r=surkov. On a CLOSED TREE

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/59f238b4844f