Closed Bug 1584312 Opened 2 months ago Closed 27 days ago

[Protections Panel] Implement section for blocked tracker milestones in the footer

Categories

(Firefox :: Protections UI, enhancement)

71 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: ewright, Assigned: nhnt11)

References

(Blocks 1 open bug)

Details

(Whiteboard: [privacy-panel])

Attachments

(2 files)

After the milestone popup from Bug 1579974 is shown we will add an illustration and extra content into the Protections Panel. This will stay for a certain period of time, and disappear after the user have interacted with it.

Blocks: 1584313
Whiteboard: [protection-report][skyline]
Whiteboard: [protection-report][skyline] → [privacy-panel][skyline]
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Summary: Add illustration to Protections Panel → [Protections Panel] Implement section for blocked tracker milestones in the footer
Whiteboard: [privacy-panel][skyline] → [privacy-panel]
Attached image aa89ec1486.png

Does this look alright? Hover/active states match the identity popup's footer as you said.

Flags: needinfo?(epang)

Spoke with you about it outside of the bug and it's looking good! Thanks!

Component: Protections UI → about:logins
Flags: needinfo?(epang)

Did you mean to move this?

Component: about:logins → Protections UI
Attachment #9097737 - Attachment description: Bug 1584312 - Implement blocked tracker count milestone UI. → Bug 1584312 - Implement blocked tracker count milestones UI. r=johannh,ewright,timhuang,flod
Attachment #9097737 - Attachment description: Bug 1584312 - Implement blocked tracker count milestones UI. r=johannh,ewright,timhuang,flod → Bug 1584312 - Implement blocked tracker count milestones UI. r=johannh,flod
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1a28547631d7
Implement blocked tracker count milestones UI. r=johannh,flod

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=1a28547631d7e62dc2ca218a9af527a4a60f075a&selectedJob=271466458

Failure logs: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271466458&repo=autoland&lineNumber=21170
https://treeherder.mozilla.org/logviewer.html#?job_id=271467500&repo=autoland

Back-out link: https://hg.mozilla.org/integration/autoland/rev/0be15ecc1848aa2d0be438baae6f60989a0f8053

[task 2019-10-16T08:13:29.630Z] 08:13:29 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI_milestones.js | Milestones section should no longer be visible in the panel. -
[task 2019-10-16T08:13:29.630Z] 08:13:29 INFO - Buffered messages finished
[task 2019-10-16T08:13:29.631Z] 08:13:29 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI_milestones.js | A promise chain failed to handle a rejection: [Exception... "Component not initialized" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: resource://gre/modules/remotepagemanager/MessagePort.jsm :: sendAsyncMessage :: line 391" data: no] - stack: sendAsyncMessage@resource://gre/modules/remotepagemanager/MessagePort.jsm:391:25
[task 2019-10-16T08:13:29.632Z] 08:13:29 INFO - sendMessage@resource:///modules/aboutpages/AboutProtectionsHandler.jsm:324:14
[task 2019-10-16T08:13:29.632Z] 08:13:29 INFO - receiveMessage@resource:///modules/aboutpages/AboutProtectionsHandler.jsm:387:14
[task 2019-10-16T08:13:29.633Z] 08:13:29 INFO - AsynccallListeners@resource://gre/modules/remotepagemanager/MessagePort.jsm:196:17
[task 2019-10-16T08:13:29.634Z] 08:13:29 INFO - portMessageReceived@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:94:19
[task 2019-10-16T08:13:29.634Z] 08:13:29 INFO - callListeners@resource://gre/modules/remotepagemanager/MessagePort.jsm:196:17
[task 2019-10-16T08:13:29.635Z] 08:13:29 INFO - handleMessage@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:266:19
[task 2019-10-16T08:13:29.635Z] 08:13:29 INFO - message@resource://gre/modules/remotepagemanager/MessagePort.jsm:355:10
[task 2019-10-16T08:13:29.636Z] 08:13:29 INFO - MessageListener.receiveMessage
addMessageListeners@resource://gre/modules/remotepagemanager/MessagePort.jsm:247:25
[task 2019-10-16T08:13:29.636Z] 08:13:29 INFO - MessagePort@resource://gre/modules/remotepagemanager/MessagePort.jsm:243:10
[task 2019-10-16T08:13:29.643Z] 08:13:29 INFO - ChromeMessagePort@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:197:5
[task 2019-10-16T08:13:29.644Z] 08:13:29 INFO - initPort@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:340:16
[task 2019-10-16T08:13:29.645Z] 08:13:29 INFO - MessageListener.receiveMessage*init@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:295:17
[task 2019-10-16T08:13:29.646Z] 08:13:29 INFO - @resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:349:27
[task 2019-10-16T08:13:29.647Z] 08:13:29 INFO - startup@resource://gre/modules/AddonManager.jsm:892:41
[task 2019-10-16T08:13:29.647Z] 08:13:29 INFO - startup@resource://gre/modules/AddonManager.jsm:3523:26
[task 2019-10-16T08:13:29.648Z] 08:13:29 INFO - observe@resource://gre/modules/addonManager.js:86:29
[task 2019-10-16T08:13:29.648Z] 08:13:29 INFO - Rejection date: Wed Oct 16 2019 08:13:22 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 265
[task 2019-10-16T08:13:29.649Z] 08:13:29 INFO - Stack trace:
[task 2019-10-16T08:13:29.655Z] 08:13:29 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:265
[task 2019-10-16T08:13:29.655Z] 08:13:29 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
[task 2019-10-16T08:13:29.656Z] 08:13:29 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1102
[task 2019-10-16T08:13:29.656Z] 08:13:29 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:930
[task 2019-10-16T08:13:29.657Z] 08:13:29 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-10-16T08:13:29.661Z] 08:13:29 INFO - Leaving test bound doTest
[task 2019-10-16T08:13:29.662Z] 08:13:29 INFO - GECKO(2019) | MEMORY STAT | vsize 3051MB | residentFast 438MB | heapAllocated 176MB
[task 2019-10-16T08:13:29.663Z] 08:13:29 INFO - TEST-OK | browser/base/content/test/siteProtections/browser_protections_UI_milestones.js | took 8780ms

Flags: needinfo?(nhnt11)

Ugh, we need to wait for about:protections to finish messaging before closing it. Fixing...

Flags: needinfo?(nhnt11)
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b649a4a3bb7e
Implement blocked tracker count milestones UI. r=johannh,flod
Status: ASSIGNED → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.