1584409 - beta simulations fail with "dom/base/TabGroup.cpp:154:14: error: unused variable 'rv'"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

I performed a simulated beta based on mozilla-central code @ 1d189ae70326e415f8590e3aeee24885fb8418bc on the try server. It fails with the changes from bug 1562663.

eg https://taskcluster-artifacts.net/QES03NcuSiiWsndnpTQkKw/0/public/logs/live_backing.log

[task 2019-09-26T23:52:20.114Z] 23:52:20 INFO - In file included from Unified_cpp_dom_base5.cpp:110:
[task 2019-09-26T23:52:20.117Z] 23:52:20 ERROR - /builds/worker/workspace/build/src/dom/base/TabGroup.cpp:154:14: error: unused variable 'rv' [-Werror,-Wunused-variable]
[task 2019-09-26T23:52:20.118Z] 23:52:20 INFO - nsresult rv = nsContentUtils::GenerateUUIDInPlace(agentClusterId);
[task 2019-09-26T23:52:20.118Z] 23:52:20 INFO - ^
[task 2019-09-26T23:52:20.118Z] 23:52:20 INFO - 1 error generated.

Is MOZ_DIAGNOSTIC_ASSERT a no-op with official branding, so that rv is unused ?

Comment 1

[Tom Tung [:tt, :ttung]]

Ah, nika has pointed out the issue on P3 in bug 1562663, but I didn't apply that to P1

Comment 2

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1584409 - Change the assertion to release to avoid unused variable on beta;

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15353385bf94
Change the assertion to release to avoid unused variable on beta; r=nika

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/15353385bf94