1584587 - Compile OSReauthenticator.cpp independently on Windows

Status: RESOLVED FIXED

(Core :: Security: PSM, task, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

OSReauthenticator.cpp includes ntsecapi.h, which defines the UNICODE_STRING structure. Unfortunately there are other, more common SDK headers that also define UNICODE_STRING, and they make no effort to keep those definitions mutually exclusive.

I'm working on some completely unrelated code that needs to drag in one of those other definitions and ends up adding it to the global namespace via ContentParent/ContentChild. Since ntsecapi.h is the less canonical definition of the structure, I propose that on Windows we isolate OSReauthenticator.cpp so that this conflict is not triggered.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1584587: Compile OSReauthenticator.cpp via SOURCES instead of UNIFIED_SOUCES on Windows; r=keeler!

We also tweak some includes in LocalCertService.cpp that are needed now that
OSReauthenticator.cpp is not part of the unified sources.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a057810d24fb
Compile OSReauthenticator.cpp via SOURCES instead of UNIFIED_SOUCES on Windows; r=keeler

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a057810d24fb