1584602 - Enforce Eval checks on Worker Threads

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Tom Ritter [:tjr]]

Bug 1583949 will land Eval checks for Worker threads; but it won't enforce them. This is so we can collect Telemetry in Nightly and ensure we don't accidentally break it because something is happening that isn't covered in our test suites.

This bug is to switch into enforcement mode.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1584602 - Enforce eval restrictions in Workers and do not enforce restrictions in Release r?ckerschb

This commit does two things. Firstly it enforces eval restrictions in Workers per Bug 1584602.
We're collecting telemetry on these in Beta (and not seeing any) so we can let enforcement ride up to Beta.

Secondly, it disables enforcement checks on Release (and late Beta, as explained in the comment) until
we can gather data about what's happening in Release. This is a counterpart to Bug 1592349 for -central.

We have two separate commits because the first part of this is a change in the same code and we'd have
rebase problems if we tried to do them both separately.

This does tie enforcement to a build-time constant instead of leaving it as a pref. This doesn't make
me very happy inside, but I don't think the extra complexity is worth it...

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cce153f4722
Enforce eval restrictions in Workers and do not enforce restrictions in Release r=ckerschb

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/8cce153f4722

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8cce153f4722