1584613 - Parental control detection doesn't work on Windows 10

Status: VERIFIED FIXED

(Core :: General, defect, P1)

Description

[Nhi Nguyen (:nhi)]

Reported at https://github.com/mozilla/doh-rollout/issues/107#issuecomment-535929384

Comment 1

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1584613 - Fix detecting web filtering parental control state on Windows 10. r=aklotz

The Windows parental controls API (e.g. IWindowsParentalControls) appears to
have been removed entirely from at least more recent builds of Windows 10. The
interfaces are still defined, but at runtime creating instances of them fails.
This patch enables us to tell if web filtering is enabled for the current user
on Windows 10 without going through that API by directly reading the relevant
registry value.

All methods of nsIParentalControlsService other than parentalControlsEnabled
have been left unimplemented because it isn't obvious how to implement them
in this environment, since no replacement for the old API seems to have been
provided. For example, it appears that loggingEnabled could be implemented
using the same registry key, but the logging mechanism is unlikely to be
compatible with the old one, so reporting that it is enabled may be unsafe.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60ad88a4c359
Fix detecting web filtering parental control state on Windows 10. r=aklotz

Comment 3

[Molly Howell (she/her) (no longer active)]

Comment on attachment 9097038 [details]
Bug 1584613 - Fix detecting web filtering parental control state on Windows 10. r=aklotz

Beta/Release Uplift Approval Request

• User impact if declined: This bug makes parental controls always appear to be disabled on Windows 10, meaning that DoH rollout logic cannot tell that it should not enable DoH because parental controls are in use.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: I've verified the fix using the STR from the original issue reported at https://github.com/mozilla/doh-rollout/issues/107.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small, targeted change limited to the parental controls service for Windows, and the new code only runs in the situation where the old code was likely not working anyway, so any regressions are highly unlikely.
• String changes made/needed:

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/60ad88a4c359

Comment 5

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

Comment on attachment 9097038 [details]
Bug 1584613 - Fix detecting web filtering parental control state on Windows 10. r=aklotz

DoH fix which may need backport to m-r. Approved for 70.0b11.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e8e31000eab2

Comment 7

[Carmen Fat [:cfat] - Ecosystem QA]

• Tested this using Nightly 71.0a1 (Build ID: 20190929213508) (64-bit) and the issue is no longer reproducible.
• Firefox detects Windows 10 Parental Control and displays the "Prefer:Safe" header in the "Request headers" section from Web Console's Network tab.

Comment 8

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

Comment on attachment 9097038 [details]
Bug 1584613 - Fix detecting web filtering parental control state on Windows 10. r=aklotz

DoH rollout blocker. Approved for 69.0.2.

Comment 9

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-release/rev/74a972765968

Comment 10

[Carmen Fat [:cfat] - Ecosystem QA]

• Tested this using Beta 70.0b11 (Build ID: 20190930132843) (64-bit) and the issue is no longer reproducible.
• Firefox detects Windows 10 Parental Control and displays the "Prefer:Safe" header in the "Request headers" section from Web Console's Network tab.

Comment 11

[Carmen Fat [:cfat] - Ecosystem QA]

• Tested this using 69.0.2 RC-build1 (Build ID: 20191001234643) (64-bit) and the issue is no longer reproducible.
• Firefox detects Windows 10 Parental Control and displays the "Prefer:Safe" header in the "Request headers" section from Web Console's Network tab.

Comment 12

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

Added to the Firefox 69.0.2 release notes:

Fixed detection of the Windows 10 Parental Controls feature being enabled

Comment 13

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.