Closed Bug 1584648 Opened 5 months ago Closed 5 months ago

Port bug 1402957 which removed nsIPermissionManager.testPermission

Categories

(MailNews Core :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(2 files, 2 obsolete files)

... and that gives a compile error.

This does the trick.

Assignee: nobody → jorgk
Attachment #9097049 - Flags: review?(mkmelin+mozilla)

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/376a47f13cc2
Port bug 1402957: Replace TestPermission with TestPermissionFromOrigin. rs=bustage-fix

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0

Sigh, there are also JS callers in two tests which fail now:

https://searchfox.org/comm-central/search?q=.testPermission&case=true&regexp=false&path=mail
mail/test/mozmill/content-policy/test-general-content-policy.js
mailnews/base/test/unit/test_accountMigration.js

Sigh, and they removed the .add function as well:
https://searchfox.org/comm-central/search?q=perms.add&case=false&regexp=false&path=mail

And the remove function as well:
https://searchfox.org/comm-central/search?q=.perms.remove&case=true&regexp=false&path=mail

Also in gData, but I'm not fixing that any more.

Attached patch 1584648-JS.patch - WIP (obsolete) — Splinter Review

Covers test in JS, not add and remove.

Attached patch 1584648-JS.patch (obsolete) — Splinter Review
Attachment #9097065 - Attachment is obsolete: true
Attachment #9097066 - Flags: review?(mkmelin+mozilla)
Attached patch 1584648-JS.patchSplinter Review

Some boy-scout clean-up to use assert_equals everywhere in the test.

Attachment #9097066 - Attachment is obsolete: true
Attachment #9097066 - Flags: review?(mkmelin+mozilla)
Attachment #9097069 - Flags: review?(mkmelin+mozilla)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c0cad9e5c5c5
Port bug 1402957: Replace TestPermission with TestPermissionFromOrigin in tests. rs=bustage-fix
Attachment #9097049 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9097069 - Flags: review?(mkmelin+mozilla) → review+
You need to log in before you can comment on or make changes to this bug.