Port bug 1402957 which removed nsIPermissionManager.testPermission
Categories
(MailNews Core :: General, defect)
Tracking
(Not tracked)
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(2 files, 2 obsolete files)
3.36 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
14.67 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
... and that gives a compile error.
Assignee | ||
Comment 1•5 years ago
|
||
This does the trick.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/376a47f13cc2
Port bug 1402957: Replace TestPermission with TestPermissionFromOrigin. rs=bustage-fix
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Sigh, there are also JS callers in two tests which fail now:
https://searchfox.org/comm-central/search?q=.testPermission&case=true®exp=false&path=mail
mail/test/mozmill/content-policy/test-general-content-policy.js
mailnews/base/test/unit/test_accountMigration.js
Assignee | ||
Comment 4•5 years ago
•
|
||
Sigh, and they removed the .add function as well:
https://searchfox.org/comm-central/search?q=perms.add&case=false®exp=false&path=mail
And the remove function as well:
https://searchfox.org/comm-central/search?q=.perms.remove&case=true®exp=false&path=mail
Also in gData, but I'm not fixing that any more.
Assignee | ||
Comment 5•5 years ago
|
||
Hmm, M-C changed that bit by bit, for example here:
https://searchfox.org/mozilla-central/rev/23f836a71cfe961373c8bd0d0219ec60a64b3c8f/browser/components/enterprisepolicies/Policies.jsm#1492
Assignee | ||
Comment 6•5 years ago
|
||
Covers test in JS, not add and remove.
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Some boy-scout clean-up to use assert_equals everywhere in the test.
Updated•5 years ago
|
Updated•5 years ago
|
Description
•