Closed
Bug 1584696
Opened 5 years ago
Closed 2 years ago
clang-format messed up various macros in nsISupportsImpl.h
Categories
(Developer Infrastructure :: Lint and Formatting, defect, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: bzbarsky, Assigned: Sylvestre)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 obsolete file)
I was trying to read some of the CC macros and not making sense of them, until I realized that the formatting was just all screwed up. Looking at https://searchfox.org/mozilla-central/diff/265e6721798a455604328ed5262f430cfcc37c2f/xpcom/base/nsISupportsImpl.h#503-516 here, for example...
There's various other stuff in that file that also got formatted pretty weirdly.
Comment 1•5 years ago
|
||
Type: task → defect
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → sledru
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
This is because clang-format isn't aware that it is a macro. By adding ";", it helps clang-format doing a better job
Updated•5 years ago
|
Keywords: regression
Updated•5 years ago
|
Priority: -- → P3
Updated•5 years ago
|
Attachment #9097338 -
Attachment is obsolete: true
Updated•3 years ago
|
Has Regression Range: --- → yes
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
Updated•2 years ago
|
Severity: normal → S3
Assignee | ||
Updated•2 years ago
|
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•