Closed Bug 1584809 Opened Last month Closed 25 days ago

PageInfo cookie permissions default to allow

Categories

(Firefox :: Page Info Window, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file)

At the moment for pageInfo cookie permissions, if Services.perms.testPermissionFromPrincipal(gPermPrincipal, "cookie") returns SitePermissions.UNKNOWN then the radio group is set to have nothing selected.
When the checkbox is unchecked, the radio group is tested and if it has nothing selected then the assumption is that the permission should be #1 i.e. ALLOW_ACTION
Should it not be the default for the relevant permission?

Flags: needinfo?(jhofmann)

Sorry, I don't really understand the issue. Maybe you could repeat this with STR/Expected Results/Actual Results?

Thanks!

Flags: needinfo?(jhofmann) → needinfo?(iann_bugzilla)

STR

  1. Configure network.cookie.lifetimePolicy to be something other than "Allow" (value of 0) e.g. "Allow For Session" (value of 2) or network.cookie.cookieBehavior set to "Block" (value of 2).
  2. Go to a website and view its Page Info
  3. Select Permissions Tab
  4. Uncheck "Use Default" on "Set Cookies"
  5. See what radio button is selected

Expected Result

  1. Radio button should be set to the radio button that closest matches the value from calculated from network.cookie.* preferences

Actual Result

  1. Radio button is always set to "Allow"
Flags: needinfo?(iann_bugzilla)

I see! Hm, you're already saying that it would be the closest we could calculate, so I would take a patch for this but generally I don't think we have an equivalent permission for all the pref states.

Priority: -- → P5
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED

As far as I can tell (with help from try), the test still passes as the default the patch picks up is still what the test expects.
Potentially another test could be written / existing test modified to set the default to something else and check for that.

Pushed by iann_cvs@blueyonder.co.uk:
https://hg.mozilla.org/integration/autoland/rev/94015d1f76fc
PageInfo cookie permissions default to allow r=johannh
Status: ASSIGNED → RESOLVED
Closed: 25 days ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.