1584920 - Add 'brx', 'bo' to Firefox Nightly build

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Francesco Lodolo [:flod]]

We need to add 'brx' to browser/locales/all-locales on mozilla-central.

PS: to be clear to the localization team, this bug is handled by Mozilla staff.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1584920 - Add Tibetan (bo) and Bodo (brx) to Firefox Nightly builds

Comment 2

[Francesco Lodolo [:flod]]

Turns out we can't add a locale without having search settings. That's surprising, given that the previous system would fall back to en-US settings.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=75022789d2e1abc94b7b204532a13f152cc56699&selectedJob=269195031

@Mark
Is this expected?

Comment 3

[Mark Banner (:standard8)]

I think what's happening here, is that the engine configuration is actually wrong and trying to ship Bing, Amazon and eBay on these new locales when it shouldn't be. My suspicion is that it could be something to do with the new default configuration added in bug 1575554 - however that should only be being used when there is no region specified.

I've filed bug 1585257 and will try and figure it out today or tomorrow.

Comment 4

[Mark Banner (:standard8)]

As I just said in bug 1585257, I've now realised this isn't the new modern configuration.

This is the legacy system that is falling back to the "default" settings, but that's not what the tests are expecting, so they're calling it out.

So probably the right thing to do for now is to add the locales to list.json with Google/DDG/Wikipedia since that's what the modern config will be shipping.

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Bug 1584920 - Add Tibetan (bo) and Bodo (brx) to Firefox Nightly builds

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3743b6fb2f3
Add Tibetan (bo) and Bodo (brx) to Firefox Nightly builds r=Pike

Comment 7

[Daniel Varga [:dvarga]]

Backed out changeset b3743b6fb2f3 (Bug 1584920) for mochitest failure in remove_imptest_failure_expectations. On a CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=269470027&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b3743b6fb2f3408201cb491fa4f3c8d69222a1a6

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269458109&repo=autoland&lineNumber=1240

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=31d06e3bb3b7256511c31f7cc91f02da7c67900a

[task 2019-10-02T15:58:02.467Z] 15:58:02     INFO -  Included file 'Z:\task_1570028969\build\tests\mochitest\tests\toolkit\content\tests\mochitest\mochitest.ini' does not exist
[task 2019-10-02T15:58:02.467Z] 15:58:02     INFO -  Included file 'Z:\task_1570028969\build\tests\mochitest\tests\toolkit\content\tests\widgets\mochitest.ini' does not exist
[task 2019-10-02T15:58:02.467Z] 15:58:02     INFO -  Included file 'Z:\task_1570028969\build\tests\mochitest\tests\toolkit\mozapps\extensions\test\mochitest\mochitest.ini' does not exist
[task 2019-10-02T15:58:02.467Z] 15:58:02     INFO -  Included file 'Z:\task_1570028969\build\tests\mochitest\tests\toolkit\xre\test\mochitest.ini' does not exist
[task 2019-10-02T15:58:02.467Z] 15:58:02     INFO -  Included file 'Z:\task_1570028969\build\tests\mochitest\tests\uriloader\exthandler\tests\mochitest\mochitest.ini' does not exist
[task 2019-10-02T15:58:02.467Z] 15:58:02     INFO -  Included file 'Z:\task_1570028969\build\tests\mochitest\tests\widget\tests\mochitest.ini' does not exist
[task 2019-10-02T15:58:02.467Z] 15:58:02    ERROR - No tests were found for flavor 'plain' and the following manifest filters:
[task 2019-10-02T15:58:02.467Z] 15:58:02    ERROR - skip_if, run_if, fail_if, remove_imptest_failure_expectations, subsuite(name=None), chunk_by_dir(1, 5, 4)
[task 2019-10-02T15:58:02.468Z] 15:58:02    ERROR - 
[task 2019-10-02T15:58:02.468Z] 15:58:02    ERROR - Make sure the test paths (if any) are spelt correctly and the corresponding
[task 2019-10-02T15:58:02.468Z] 15:58:02    ERROR - --flavor and --subsuite are being used. See `mach mochitest --help` for a
[task 2019-10-02T15:58:02.468Z] 15:58:02    ERROR - list of valid flavors.
[task 2019-10-02T15:58:02.468Z] 15:58:02    ERROR - 
[task 2019-10-02T15:58:02.468Z] 15:58:02     INFO - SUITE-START | Running 0 tests
[task 2019-10-02T15:58:02.468Z] 15:58:02     INFO -  0 INFO TEST-START | Shutdown
[task 2019-10-02T15:58:02.468Z] 15:58:02     INFO -  1 INFO Passed:  0
[task 2019-10-02T15:58:02.468Z] 15:58:02     INFO -  2 INFO Failed:  0
[task 2019-10-02T15:58:02.468Z] 15:58:02     INFO -  3 INFO Todo:    0
[task 2019-10-02T15:58:02.468Z] 15:58:02     INFO -  4 INFO Mode:    e10s
[task 2019-10-02T15:58:02.468Z] 15:58:02     INFO -  5 INFO SimpleTest FINISHED
[task 2019-10-02T15:58:02.469Z] 15:58:02     INFO - Buffered messages finished
[task 2019-10-02T15:58:02.469Z] 15:58:02     INFO - SUITE-END | took 0s
[task 2019-10-02T15:58:02.502Z] 15:58:02    ERROR - Return code: 1
[task 2019-10-02T15:58:02.502Z] 15:58:02    ERROR - No checks run.
[task 2019-10-02T15:58:02.502Z] 15:58:02     INFO - TinderboxPrint: mochitest-mochitest-plain-chunked<br/><em class="testfail">T-FAIL</em>
[task 2019-10-02T15:58:02.502Z] 15:58:02    ERROR - # TBPL FAILURE #
[task 2019-10-02T15:58:02.503Z] 15:58:02  WARNING - setting return code to 2
[task 2019-10-02T15:58:02.503Z] 15:58:02    ERROR - The mochitest suite: mochitest-plain-chunked ran with return status: FAILURE
[task 2019-10-02T15:58:02.503Z] 15:58:02     INFO - Running post-action listener: _package_coverage_data
[task 2019-10-02T15:58:02.503Z] 15:58:02     INFO - Running post-action listener: _resource_record_post_action
[task 2019-10-02T15:58:02.503Z] 15:58:02     INFO - Running post-action listener: process_java_coverage_data
[task 2019-10-02T15:58:02.503Z] 15:58:02     INFO - [mozharness: 2019-10-02 15:58:02.503000Z] Finished run-tests step (success)
[task 2019-10-02T15:58:02.503Z] 15:58:02     INFO - Running post-run listener: _resource_record_post_run

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08c88f5fbbc1
Backed out changeset b3743b6fb2f3 for mochitest failure in remove_imptest_failure_expectations. On a CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2de4e03f0ba
Add Tibetan (bo) and Bodo (brx) to Firefox Nightly builds r=Pike. On a CLOSED TREE

Comment 10

[Francesco Lodolo [:flod]]

Failure seems unrelated.

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/a2de4e03f0ba

Comment 12

[Francesco Lodolo [:flod]]

Attachment: Bug 1604415 - Add Sicilian (scn) to Firefox Nightly Builds

Comment 13

[Phabricator Automation]

Comment on attachment 9116326 [details]
Bug 1604415 - Add Sicilian (scn) to Firefox Nightly Builds

Revision D57433 was moved to bug 1604415. Setting attachment 9116326 [details] to obsolete.