Closed Bug 1584927 Opened 1 year ago Closed 1 year ago

Update "Take Element Screenshot" and "Take Screenshot" user prompt tests to respect unhandled prompt behavior

Categories

(Testing :: Marionette, task, P1)

Version 3
task

Tracking

(firefox-esr68 wontfix, firefox70 wontfix, firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr68 --- wontfix
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Based on the changes from https://github.com/web-platform-tests/wpt/pull/17563 we will have to add user prompt checks to screenshot commands to be compliant with the WebDriver spec.

The test changes will be merged in with bug 1583401.

James, when I provide a fix for that quickly, could we delay landing of the sync without marking all the tests as expected fail? Or should we better wait for this downstream sync to be done?

I would like to see this fix also landed for 70 and 68ESR if possible.

Flags: needinfo?(james)

I think my question has been solved on its own. We cannot get this landed because it needs the changes to those tests. Lets wait until the downstream sync has been landed.

Flags: needinfo?(james)
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d85038a038b
[marionette] Handle user prompts in "Take Element Screenshot" and "Take Screenshot" commands. r=webdriver-reviewers,ato
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Is this still something you're hoping to get into Fx70? The RC build is Monday.

Flags: needinfo?(hskupin)

We cannot uplift this patch until also bug 1583401 gets uplifted. Given that nothing is broken in beta, I don't think we will actually do that. It can perfectly ride the trains. But thanks for asking.

Flags: needinfo?(hskupin)

Or lets say it this way, if uplifting bug 1583401 doesn't cause problems, it would be great to have also this patch uplifted.

Missed to set the whiteboard entries, and now it is too late. Lets not worry about it, but see it fixed in 71.

You need to log in before you can comment on or make changes to this bug.