1584927 - Update "Take Element Screenshot" and "Take Screenshot" user prompt tests to respect unhandled prompt behavior

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Based on the changes from https://github.com/web-platform-tests/wpt/pull/17563 we will have to add user prompt checks to screenshot commands to be compliant with the WebDriver spec.

The test changes will be merged in with bug 1583401.

James, when I provide a fix for that quickly, could we delay landing of the sync without marking all the tests as expected fail? Or should we better wait for this downstream sync to be done?

I would like to see this fix also landed for 70 and 68ESR if possible.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I think my question has been solved on its own. We cannot get this landed because it needs the changes to those tests. Lets wait until the downstream sync has been landed.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1584927 - [marionette] Handle user prompts in "Take Element Screenshot" and "Take Screenshot" commands. r=#webdriver

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d85038a038b
[marionette] Handle user prompts in "Take Element Screenshot" and "Take Screenshot" commands. r=webdriver-reviewers,ato

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8d85038a038b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this still something you're hoping to get into Fx70? The RC build is Monday.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We cannot uplift this patch until also bug 1583401 gets uplifted. Given that nothing is broken in beta, I don't think we will actually do that. It can perfectly ride the trains. But thanks for asking.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Or lets say it this way, if uplifting bug 1583401 doesn't cause problems, it would be great to have also this patch uplifted.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Missed to set the whiteboard entries, and now it is too late. Lets not worry about it, but see it fixed in 71.