Closed
Bug 158498
Opened 22 years ago
Closed 22 years ago
defparams.pl prints an error message in a check function instead of returning it
Categories
(Bugzilla :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: gerv, Assigned: gerv)
Details
Attachments
(1 file)
|
787 bytes,
patch
|
jayvdb
:
review+
jayvdb
:
review+
|
Details | Diff | Splinter Review |
defparams.pl: print "Dependency graph images are not
accessible.\nDelete data/webdot/.htaccess and re-run checksetup.pl to rectify.\n";
I think this needs to be returned by the function, as happens for errors in the
other check* functions, for printing elsewhere.
CCing zeroj, who wrote this code, for confirmation.
Gerv
|
||
Comment 1•22 years ago
|
||
There was no special reason for the print. Thanks for picking it up.
|
Assignee | |
Comment 2•22 years ago
|
||
zeroj: please rubberstamp. Filing a whole review request would be overkill.
Gerv
|
|
||
Comment 3•22 years ago
|
||
Comment on attachment 92201 [details] [diff] [review]
Patch v.1
rx2=zeroj
Attachment #92201 -
Flags: review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Fixed. Thanks :-)
Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v <-- defparams.pl
new revision: 1.79; previous revision: 1.78
done
Gerv
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•22 years ago
|
Target Milestone: --- → Bugzilla 2.18
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•