Closed Bug 1585056 Opened 5 years ago Closed 4 years ago

Green up failing APZ reftests on Android with WebRender

Categories

(Core :: Graphics: WebRender, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: botond, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: wr-android)

Some APZ reftests are marked as failing on Android with WebRender:

  • in layout/reftests/async-scrolling:
    • checkerboard-2.html
    • checkerboard-3.html
    • position-fixed-async-zoom-1.html
    • position-sticky-async-zoom-1.html
    • dynamic-toolbar-fixed-bottom-1.html
  • in gfx/layers/apz/test/reftest:
    • pinch-zoom-position-sticky.html (this is tracked in bug 1569339)

We should get these tests passing. The position-{fixed,sticky}-async-zoom-1.html tests in particular indicate that we haven't implemented correct positioning of fixed and sticky content when zoomed in, which can be quite user-noticeable.

Summary: Green up failing APZ mochitests on Android with WebRender → Green up failing APZ reftests on Android with WebRender
Priority: -- → P3
No longer blocks: wr-android-mvp
Blocks: wr-74-android
No longer blocks: wr-73-android
Depends on: 1609002

Ran through these tests locally and they are passing now.
Closing issue.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

(In reply to Botond Ballo [:botond] [spotty responses until Feb 19] from comment #0)

  • dynamic-toolbar-fixed-bottom-1.html

This one still has a fails-if(geckoview&&webrender) annotation.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Good catch botond, only noticed the skip-if(!android) annotation.

Just tried running this and it is still failing.

No longer blocks: wr-74-android
Blocks: wr-android
Whiteboard: wr-android

(In reply to Botond Ballo [:botond] from comment #2)

(In reply to Botond Ballo [:botond] [spotty responses until Feb 19] from comment #0)

  • dynamic-toolbar-fixed-bottom-1.html

This one still has a fails-if(geckoview&&webrender) annotation.

This one was fixed in bug 1610731.

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.