Closed Bug 1585058 Opened 2 months ago Closed 2 months ago

Typo in identifier causing the test to return always the same value

Categories

(Core :: DOM: Security, defect, P1)

Product:
Core
Component:
DOM: Security
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: coverity, regression, Whiteboard: [CID 98712][domsecurity-active])

Attachments

(1 file)

Bug 1585058 - Typo in identifier causing the test to return always the same value r?tnguyen
47 bytes, text/x-phabricator-request
lizzard
: approval-mozilla-beta+
Details | Review

https://dxr.mozilla.org/mozilla-central/source/toolkit/content/contentAreaUtils.js?q=orginalReferrer&redirect_type=single#503

identifier_typo: Using orginalReferrer appears to be a typo:
    Identifier orginalReferrer is only known to be referenced here, or in copies of this code.
    Identifier originalReferrer is referenced elsewhere at least 7 times.
Summary: Typo in identifier → Typo in identifier causing the test to return always the same value
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a269edb06c2
Typo in identifier causing the test to return always the same value r=tnguyen

thanks for fixing!

Assignee: nobody → sledru
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [CID 98712] → [CID 98712][domsecurity-active]

https://hg.mozilla.org/mozilla-central/rev/8a269edb06c2

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Is this something we need to nominate for Beta uplift or can it ride Fx71 to release?

status-firefox67: --- → unaffected
status-firefox68: --- → unaffected
status-firefox69: --- → unaffected
status-firefox70: --- → affected
status-firefox-esr60: --- → unaffected
status-firefox-esr68: --- → unaffected
Flags: needinfo?(sledru)

Dunno, I am just fixing an engineering issue, I don't know what is the actual defect on the product(s).
Christoph?

Flags: needinfo?(sledru) → needinfo?(ckerschb)
Flags: needinfo?(tnguyen)

It should be uplifted I think

Flags: needinfo?(tnguyen)
Flags: needinfo?(ckerschb)

Comment on attachment 9097412 [details]
Bug 1585058 - Typo in identifier causing the test to return always the same value r?tnguyen

Beta/Release Uplift Approval Request

  • User impact if declined: Not found at the moment, but it is a wrong logic because of typo
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Typo orignalReferrer-> originalReferrer, then we use related uri from referrer
  • String changes made/needed:
Attachment #9097412 - Flags: approval-mozilla-beta?

Comment on attachment 9097412 [details]
Bug 1585058 - Typo in identifier causing the test to return always the same value r?tnguyen

Correctness issue, unsure of impact but let's uplift.

Attachment #9097412 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.