Closed Bug 1585078 Opened 1 year ago Closed 6 months ago

Audit usage of nsIDocShellTreeItem in GetRootWindow

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Fission Milestone M6
Tracking Status
firefox77 --- fixed

People

(Reporter: djvj, Assigned: tetsuharu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:hard])

Attachments

(2 files, 1 obsolete file)

https://searchfox.org/mozilla-central/rev/45f30e1d19bde27bf07e47a0a5dd0962dd27ba18/dom/base/Document.cpp#13621

Check users of this method, because it cannot survive as is. All users need to be fixed to use alternative mechanisms that don't involve directly manipulating the root window.

Fission Milestone: --- → M5
Priority: -- → P2
Whiteboard: [rm-docshell-tree-item:hard]
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
Summary: Fix usage of nsIDocShellTreeItem in GetRootWindow → Audit usage of nsIDocShellTreeItem in GetRootWindow
Attached file Bug 1585078 - WIP (obsolete) —

I seem we should refactor dom::Document::RequestFullscreen into separate paths for content process and no-conent process before tackling to remove GetRootWindow from Document.cpp

Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Attachment #9142374 - Attachment is obsolete: true
Attachment #9142402 - Attachment description: Bug 1585078 - part 2: Replace `GetRootWindow()` in Document.cpp with BrowsingContext. → Bug 1585078 - part 2: Remove calling `GetRootWindow()` from the the parent process.
Attachment #9142402 - Attachment description: Bug 1585078 - part 2: Remove calling `GetRootWindow()` from the the parent process. → Bug 1585078 - part 2: Remove calling `GetRootWindow()` from the the child process.
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5657eec0de4c
part 1: Divide `Document::RequestFullScreen()` into seperate path to clarify the case in content process. r=nika
https://hg.mozilla.org/integration/autoland/rev/71cb60d53ecd
part 2: Remove calling `GetRootWindow()` from the the child process. r=nika
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.