Closed Bug 1585079 Opened 4 months ago Closed 1 month ago

Fix usage of nsIDocShellTreeItem in Document::GetSameTypeParentDocument

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla74
Fission Milestone M6
Tracking Status
firefox74 --- fixed

People

(Reporter: djvj, Assigned: Nika)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:hard])

Attachments

(4 files)

https://searchfox.org/mozilla-central/rev/45f30e1d19bde27bf07e47a0a5dd0962dd27ba18/dom/base/Document.cpp#15310

Rename this function GetInProcessSameTypeParentDocument, and audit uses. After changes, it should return NULL for out-of-process parents.

Alternatively, this method might need to go away, if making this method unusable for OOP parents makes it nearly worthless for its users.

Fission Milestone: --- → M5
Priority: -- → P2
Whiteboard: [rm-docshell-tree-item:hard]
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
Assignee: nobody → nika
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae770c4a16b0
Part 1: Support Document::GetBrowsingContext early during Document lifecycle, r=smaug
https://hg.mozilla.org/integration/autoland/rev/58c51eb6a095
Part 2: Remove GetSameTypeParentDocument from InitReferrerInfo, r=baku
https://hg.mozilla.org/integration/autoland/rev/ba050445b3c9
Part 3: Remove GetSameTypeParentDocument from MaybeStoreUserInteractionAsPermission, r=baku
https://hg.mozilla.org/integration/autoland/rev/c99a28a11899
Part 4: Remove GetSameTypeParentDocument, r=smaug
You need to log in before you can comment on or make changes to this bug.