1585099 - esr68 branch fails to build with rust 1.38

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Landry Breuil (:gaston)]

Rust was updated to 1.38 in OpenBSD, and as a side effect thunderbird 68 & firefox-esr 68 now fail to build, choking on cssparser - see https://marc.info/?l=openbsd-ports&m=156984549605237&w=2 for the original report/bugfix.

sebastien found out that backporting https://github.com/servo/rust-cssparser/pull/245/commits/3c98d22c5de3b696bf1fde2b6c90069812312aa6 on top of third-party/rust/cssparser/src/parser.rs was enough to fix the build with rust 1.38.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1585099 - Update cssparser to 0.25.5 on ESR68, to avoid warning that became a hard error.

The changes look big because of the reformatting, but this should be ok, I'd
think.

I could've manually cherry-picked the particular fix and used [patch] or
something, but the particular commit didn't apply cleanly and I think it's
better to just update to a published version.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9097723 [details]
Bug 1585099 - Update cssparser to 0.25.5 on ESR68, to avoid warning that became a hard error.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build fix.
• User impact if declined: None
• Fix Landed on Version: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Update that has been on our tree since forever and that mostly peeks up the cleanups here.
• String or UUID changes made by this patch: none

Comment 4

[Cameron McCormack (:heycam)]

The bar for porting changes to ESR should be pretty high. Can people building ESR install Rust 1.34 and build with that? https://hg.mozilla.org/releases/mozilla-esr68/file/tip/build/moz.configure/rust.configure#l144 Or does that not work for some reason?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

(In reply to Cameron McCormack (:heycam) from comment #4)

The bar for porting changes to ESR should be pretty high. Can people building ESR install Rust 1.34 and build with that? https://hg.mozilla.org/releases/mozilla-esr68/file/tip/build/moz.configure/rust.configure#l144 Or does that not work for some reason?

Well I'll forward this to Landry.

Generally I think build-fixes are reasonable to uplift to ESR, specially if they're low-effort... Let me know if you prefer a more minimal (but manually written rather than automatically written) patch.

Comment 6

[Emerson Bernier]

(In reply to Cameron McCormack (:heycam) from comment #4)

The bar for porting changes to ESR should be pretty high. Can people building ESR install Rust 1.34 and build with that? https://hg.mozilla.org/releases/mozilla-esr68/file/tip/build/moz.configure/rust.configure#l144 Or does that not work for some reason?

Do you think it's easy for all vendors to bring special rust version for building FF/TB ESR? No it isn't. It's several orders of magnitude easier to patch the code. Now, the question is if everyone would have to patch it themselves or upstream will patch it once for all.

Comment 7

[Landry Breuil (:gaston)]

(In reply to Cameron McCormack (:heycam) from comment #4)

The bar for porting changes to ESR should be pretty high. Can people building ESR install Rust 1.34 and build with that? https://hg.mozilla.org/releases/mozilla-esr68/file/tip/build/moz.configure/rust.configure#l144 Or does that not work for some reason?

sorry but no, people building ESR can't install rust 1.34. OpenBSD packages one version of rust (the latest) and doesn't have rustup available, so that's a no-go.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

FYI, we need to build 68.2esr RC builds next week. Can we please make a decision on this bug?

Comment 9

[Cameron McCormack (:heycam)]

Thanks, not having rustup available is the context I was missing.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9097723 [details]
Bug 1585099 - Update cssparser to 0.25.5 on ESR68, to avoid warning that became a hard error.

Minor cssparser update to pick up upstream warning fixes which cause bustage with newer versions of Rust, making life difficult for downstream distros. Approved for 68.2esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/f0020f517832