1585356 - Investigate Bug 1448483 and see if it can be backed out

Status: RESOLVED WONTFIX

(Firefox Build System :: General: Unsupported Platforms, task)

Comment 1

[Tom Ritter [:tjr]]

So this has caused an intermittent in a reftest: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=269597580&revision=7266887df5d2f7ac301fb5b83ed70a755db1678e

Given that we're changing a hashing function this seems within the realm of possibility. Leaving this to deal with later and to see if I ever see this intermittent outside of this patch

Comment 2

[Tom Ritter [:tjr]]

I've seen this intermittent elsewhere now, so this can be reverted....

Comment 3

[Tom Ritter [:tjr]]

Attachment: Bug 1585356 - Back out changeset 149a759643fb reverting CityHash changes for mingw-gcc r?froydnj

The changes made to CityHash are no longer necessary with mingw-clang, so we
can revert them to the original upstream implementation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbbb42a15738
Back out changeset 149a759643fb reverting CityHash changes for mingw-gcc r=froydnj

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for bustage on city.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/ed231a582c86238039291c79bffd5abf3087feb5

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fbbb42a15738a7cc2eb05c17eeac20e40d8b4422&group_state=expanded&selectedJob=283906151

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283906151&repo=autoland&lineNumber=4862

[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/modules/libmar/tool'
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - z:/build/fetches/sccache/sccache.exe z:/build/fetches/clang/bin/clang-cl.exe -Xclang -std=c++17 -Fohost_city.obj -c -O2 -DNDEBUG=1 -DTRIMMED=1 -DNO_SIGN_VERIFY '-DMAR_CHANNEL_ID="firefox-mozilla-central"' '-DMOZ_APP_VERSION="74.0a1"' -Iz:/build/build/src/modules/libmar/tool -Iz:/build/build/src/obj-firefox/modules/libmar/tool -Iz:/build/build/src/obj-firefox/dist/include -Xclang -MP -Xclang -dependency-file -Xclang .deps/host_city.obj.pp -Xclang -MT -Xclang host_city.obj -Iz:/build/build/src/obj-firefox/dist/include/nspr z:/build/build/src/other-licenses/nsis/Contrib/CityHash/cityhash/city.cpp
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - z:/build/build/src/other-licenses/nsis/Contrib/CityHash/cityhash/city.cpp(226,3): error: unknown type name 'ssize_t'
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - ssize_t l = len - 16;
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - ^
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - 1 error generated.
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - z:/build/build/src/config/rules.mk:672: recipe for target 'host_city.obj' failed
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - mozmake.EXE[4]: *** [host_city.obj] Error 1
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/modules/libmar/tool'
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - z:/build/build/src/config/recurse.mk:74: recipe for target 'modules/libmar/tool/host-objects' failed
[task 2020-01-07T22:44:55.495Z] 22:44:55 INFO - mozmake.EXE[3]: *** [modules/libmar/tool/host-objects] Error 2
[task 2020-01-07T22:44:55.496Z] 22:44:55 INFO - mozmake.EXE[3]: *** Waiting for unfinished jobs....

Comment 7

[Tom Ritter [:tjr]]

Okay; never mind.