1585421 - Have the Static Prefs linter detect duplicates in more pref files

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Description

[Kris Wright :KrisWright]

There are several pref files that could potentially contain duplicates with StaticPrefList.yaml that aren't currently being linted, such as:

browser/app/profile/firefox.js
mobile/android/app/mobile.js
devtools/client/preferences/debugger.js
mobile/android/app/geckoview-prefs.js
browser/branding/official/pref/firefox-branding.js
browser/branding/nightly/pref/firefox-branding.js
browser/branding/unofficial/pref/firefox-branding.js
browser/branding/aurora/pref/firefox-branding.js
browser/app/profile/channel-prefs.js
mobile/android/installer/mobile-l10n.js
mobile/android/locales/en-US/mobile-l10n.js

To properly detect duplication between these files may require some extra consideration (such as the value field), which I noted in in this bug. As of right now lintpref only cares about the names of prefs.

Comment 1

[Kris Wright :KrisWright]

Attachment: Bug 1585421 - Expand the usage of Lintpref into more pref files

Adds the filepaths of more pref files to Lintpref as well as to its TaskCluster entry. All of the pref files added are noted in bug 1585421.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92b79faea252
Expand the usage of Lintpref into more pref files r=ahal

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/92b79faea252