1585439 - Incorrect assertion in nsDOMWindowUtils::GetVisitedDependentComputedStyle(

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P3)

Description

[Beth Rennie [:beth] (she/her)]

In nsDOMWindowUtils::GetVisitedDependentComputedStyle there is the following code with assertions

  nsCOMPtr<nsPIDOMWindowOuter> window = do_QueryReferent(mWindow);
  NS_ENSURE_STATE(window && aElement);
  nsCOMPtr<nsPIDOMWindowInner> innerWindow = window->GetCurrentInnerWindow();
  NS_ENSURE_STATE(window); // <--

This should be an assertion of innerWindow as we've already checked that window exists.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Shrey Gupta]

Hi, I would like to contribute to this bug. It is my first bug fix so could you please guide me and tell me how to proceed.
Thanks

Comment 3

[Shrey Gupta]

Attachment: Bug 1585439 - Changed assertion of window to innerWindow. r=bzbarsky

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 5

[Nekesa Patricia]

Hello, Kindly assign me this bug to work on

Comment 6

[Jens Stutte [:jstutte]]

(In reply to Nekesa Patricia from comment #5)

Hello, Kindly assign me this bug to work on

Great! Feel free to just submit a patch here following our contribution quickref. This will automatically assign the bug to you. I will abandon the old one that has never been completed.

Comment 7

[Suhaib Mujahid [:suhaib]]

Attachment: Bug 1585439 - Replace assertion of window with innerWindow. r=bzbarsky

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/498161493c3b
Replace assertion of window with innerWindow. r=mccr8

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/498161493c3b