1585484 - Make `mach browsertime --setup` install `geckodriver` from toolchain tasks

Status: NEW

(Testing :: Performance, task, P3)

Description

[Nick Alexander :nalexander [he/him]]

Right now we install a custom geckodriver with preliminary support for Android that I uploaded to Github. See Bug 1556567. But we now have toolchain geckodriver builds (Bug 1534533) with support for Android out of the box (Bug 1525126 and friends). We definitely want a newer geckodriver, and my guess is that using the newest toolchain build will be better than tracking Geckodriver releases explicitly.

Comment 1

[Nick Alexander :nalexander [he/him]]

This could look like using the artifact installation logic from mach bootstrap in mach browsertime --setup: see https://searchfox.org/mozilla-central/rev/f372e8a46ef7659ef61be9938ec2a3ea34d343c6/python/mozboot/mozboot/base.py#309-328.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Note that you will use developer builds when doing that right now. Maybe for the time being you might want to pin a specific changeset for the download? In the future we want to release geckodriver from taskcluster, but there is still a bit of work to do.

You might also want to use the signed builds of geckodriver to prevent issues with AV software right after releases, or any kind of change to geckodriver. I assume it's not only CI which runs the tests, but also developers on their local machines.

Comment 3

[Robert Wood [:rwood]]

Note: Using the official release v0.26 of geckodriver does work when running raptor browsertime on GVE app; so looks like we should be able to move to using the release one instead of the custom driver.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Great to hear! I made a couple of changes based on Nick's WiP, so I cannot tell what actually could have fixed it. But yes, please use the official version of geckodriver for that purpose.

Comment 5

[Greg Mierzwinski [:sparky]]

:tarek, are you currently working on this? If you're not actively hacking on this anymore, can you unassign yourself and set it to P3?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Now that we do not use a custom geckodriver anymore but a release via browsertime, maybe this bug isn't that important anymore? I would still see benefits from being able to utilize new features and bug fixes in geckodriver before a new release of it happened. But how often is that the case? Feel free to set it back to P2 if it is, otherwise I will follow Greg's advice with P3 for now.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Now that we do not use a custom geckodriver anymore but a release via browsertime, maybe this bug isn't that important anymore? I would still see benefits from being able to utilize new features and bug fixes in geckodriver before a new release of it happened. But how often is that the case? Feel free to set it back to P2 if it is, otherwise I will follow Greg's advice with P3 for now.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It's been a few years without any updates, and worth asking if there's still value in keeping this bug open.

Comment 9

[Greg Mierzwinski [:sparky]]

This bug is still valid. We currently use the browsertime geckodriver locally, but it's different from the one we use in tests in CI.