1585487 - [Protections Panel] Update info message animation

Status: RESOLVED FIXED

(Firefox :: Site Identity, enhancement, P3)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Eric says we should eliminate motion for the text and have the panel contents slide down to reveal the info message already in place. And as this happens, fade in the info message contents from 0 opacity to 100%.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1585487 - Update protections panel info message animation. r=andreio,johannh

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: media.io_Screen Recording 2019-10-01 at 11.34.19 PM.webm

This is what it looks like - but I updated the patch after this recording so take it with a grain of salt. I also updated the header gradient to end at the edge of the panel rather than the bottom corner - since the bottom corner is now variable. This way, the gradient won't seem to change when the info message is opened.

Comment 3

[Eric Pang [:epang] UX]

this looks great, thanks Nihanth! Excited to see it in nightly!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05273fba6dad
Update protections panel info message animation. r=johannh

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/05273fba6dad

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9097811 [details]
Bug 1585487 - Update protections panel info message animation. r=andreio,johannh

Beta/Release Uplift Approval Request

• User impact if declined: Excessive motion in the animation of the Protections Panel info message.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Visual polish - CSS only. Verified via screen recording (comment 2 and comment 3)
• String changes made/needed:

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9097811 [details]
Bug 1585487 - Update protections panel info message animation. r=andreio,johannh

Clearing approval request due to a regression.

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1585487 - Revert info message animation change. r=johannh

Comment 9

[Phabricator Automation]

Comment on attachment 9099777 [details]
Bug 1585487 - Revert info message animation change. r=johannh

Revision D48641 was moved to bug 1587316. Setting attachment 9099777 [details] to obsolete.