Closed
Bug 1585526
Opened 6 years ago
Closed 6 years ago
[BinAST] Remove Variant::match call where the parameter type is known
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(2 files)
there are some case that the caller of a certain method wraps a type in a Variant and then the callee method immediately branches on types by Variant::match.
Such case can be optimized away by adding thin template method or direcly call the inner method/codelet
|
Assignee | |
Comment 1•6 years ago
|
||
Depends on D48015
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D48016
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/ab13ef2740e0
Part 1: Remove unnecessary Variant::match in HuffmanPreludeReader::pushValue. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/552a3c5dedd7
Part 2: Remove unnecessary Variant::match in BinASTTokenReaderContext::readTagFromTable. r=Yoric
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ab13ef2740e0
https://hg.mozilla.org/mozilla-central/rev/552a3c5dedd7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•