1585564 - [wpt-sync] Sync PR 19462 - Worklet: Reject addModule() with script's error to rethrow if available

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19462 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19462
Details from upstream follow.

Hiroki Nakagawa <[e-mail]> wrote:

Worklet: Reject addModule() with script's error to rethrow if available

This CL makes Worklet#addModule() fail with a more specific error object
compared to before.

Before this change, Worklet::addModule() was rejected with AbortError regardless
of an actual error reason, and that made it difficult for developers to debug
worklets. This behavior was defined in the Worklets spec, but it was changed
recently (see the links below).

After this change, Worklet::addModule() is rejected with script's error to
rethrow when it is available as the new spec defines.

Spec changes:

• https://github.com/w3c/css-houdini-drafts/pull/958
• https://github.com/w3c/css-houdini-drafts/pull/967

Chromestatus:

• https://www.chromestatus.com/feature/5116796497559552

Bug: 782066
Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2

Reviewed-on: https://chromium-review.googlesource.com/1258785
WPT-Export-Revision: 5c6426b637e7a1bfc7ae5fa0057de9982067186c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d115a1c5ca37e25ac91ab3a60aa3632339ca408

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3897aef3d688ad28be60394728cf8ff829235869

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0efe299097720c2a4b12d2acc75c9fbd02d690d

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d1acd9dce677fcb51fd554baf6ad2af3c7c4579

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=71e5db7a9b6b85a130d06c9cd0b3e93dd18b2c9e

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=90c1492bb7ece478bccae23b8401177c57730e79

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=24e2bfc4325b99d7ac9638487b01ea28ac6d4cf3

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=11b16a85b545cbb32e284802f924cad2d8539ccd&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=11b16a85b545cbb32e284802f924cad2d8539ccd&label=pr_base)

Ran 4 tests and 73 subtests

### Firefox
  OK     : 4
  FAIL   : 72

### Chrome
  OK     : 4
  PASS   : 60
  FAIL   : 12

### Safari
  OK     : 4
  FAIL   : 55

### New tests that's don't pass

/worklets/audio-worklet-import.https.html
   audio-worklet-import: Firefox: MISSING, Chrome: MISSING, Safari: FAIL

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be5a525dc0ae
[wpt PR 19462] - Worklet: Reject addModule() with script's error to rethrow if available, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/26b70e39b259
[wpt PR 19462] - Update wpt metadata, a=testonly

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/be5a525dc0ae
https://hg.mozilla.org/mozilla-central/rev/26b70e39b259