Closed Bug 1585564 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19462 - Worklet: Reject addModule() with script's error to rethrow if available

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19462 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19462
Details from upstream follow.

Hiroki Nakagawa <nhiroki@chromium.org> wrote:

Worklet: Reject addModule() with script's error to rethrow if available

This CL makes Worklet#addModule() fail with a more specific error object
compared to before.

Before this change, Worklet::addModule() was rejected with AbortError regardless
of an actual error reason, and that made it difficult for developers to debug
worklets. This behavior was defined in the Worklets spec, but it was changed
recently (see the links below).

After this change, Worklet::addModule() is rejected with script's error to
rethrow when it is available as the new spec defines.

Spec changes:

Chromestatus:

Bug: 782066
Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2

Reviewed-on: https://chromium-review.googlesource.com/1258785
WPT-Export-Revision: 5c6426b637e7a1bfc7ae5fa0057de9982067186c

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=11b16a85b545cbb32e284802f924cad2d8539ccd&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=11b16a85b545cbb32e284802f924cad2d8539ccd&label=pr_base)

Ran 4 tests and 73 subtests

### Firefox
  OK     : 4
  FAIL   : 72

### Chrome
  OK     : 4
  PASS   : 60
  FAIL   : 12

### Safari
  OK     : 4
  FAIL   : 55

### New tests that's don't pass

/worklets/audio-worklet-import.https.html
   audio-worklet-import: Firefox: MISSING, Chrome: MISSING, Safari: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be5a525dc0ae
[wpt PR 19462] - Worklet: Reject addModule() with script's error to rethrow if available, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/26b70e39b259
[wpt PR 19462] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/be5a525dc0ae
https://hg.mozilla.org/mozilla-central/rev/26b70e39b259

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.