Closed
Bug 1585568
Opened 5 years ago
Closed 5 years ago
[BinAST] Optimize away {AutoBase,AutoList,AutoTaggedTuple} allocation and method invocation
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(2 files)
AutoBase
, AutoList
, and AutoTaggedTuple
for Context are no-op in opt-build,
but given they're not inlined, they're not optimizable.
Assignee | ||
Comment 1•5 years ago
|
||
AutoBase::init is almost no-op in opt-build, but given
enterTaggedTuple/enterList isn't inlinable, the parameter cannot be optimized
out, thus the constructor call is also not optimizable.
Moved out the call, in order to make them optimizable in the next patch.
Depends on D48018
Assignee | ||
Comment 2•5 years ago
|
||
{AutoBase,AutoTaggedTuple,AutoList} in BinASTTokenReaderContext is almost no-op
in opt-build.
Made them completely no-op, so that the allocation/call can be optimized out.
Depends on D48019
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/eb0ba91fc18a Part 1: Move guard.init out of enterTaggedTuple/enterList in order to make it possible to optimize the call away. r=Yoric https://hg.mozilla.org/integration/autoland/rev/84a9abe7de80 Part 2: Inline {AutoBase,AutoTaggedTuple,AutoList} methods and remove debug-only fields. r=Yoric
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb0ba91fc18a
https://hg.mozilla.org/mozilla-central/rev/84a9abe7de80
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•