1585568 - [BinAST] Optimize away {AutoBase,AutoList,AutoTaggedTuple} allocation and method invocation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

AutoBase, AutoList, and AutoTaggedTuple for Context are no-op in opt-build,
but given they're not inlined, they're not optimizable.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1585568 - Part 1: Move guard.init out of enterTaggedTuple/enterList in order to make it possible to optimize the call away. r?Yoric

AutoBase::init is almost no-op in opt-build, but given
enterTaggedTuple/enterList isn't inlinable, the parameter cannot be optimized
out, thus the constructor call is also not optimizable.

Moved out the call, in order to make them optimizable in the next patch.

Depends on D48018

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1585568 - Part 2: Inline {AutoBase,AutoTaggedTuple,AutoList} methods and remove debug-only fields. r?Yoric

{AutoBase,AutoTaggedTuple,AutoList} in BinASTTokenReaderContext is almost no-op
in opt-build.
Made them completely no-op, so that the allocation/call can be optimized out.

Depends on D48019

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb0ba91fc18a
Part 1: Move guard.init out of enterTaggedTuple/enterList in order to make it possible to optimize the call away. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/84a9abe7de80
Part 2: Inline {AutoBase,AutoTaggedTuple,AutoList} methods and remove debug-only fields. r=Yoric

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/eb0ba91fc18a
https://hg.mozilla.org/mozilla-central/rev/84a9abe7de80