1585630 - Avoid remoteness change in browser_page_frameNavigated* tests in order to enable tests on Fission

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P1)

Description

[Andreas Tolfsen ❲:ato❳]

There is an overview in the Fission mochitest spreadsheet of
Fission-only failing tests. As I outlined in bug 1585464 comment
#2 most of the remote tests pass under Fission and can be enabled
without any changes.

The browser_page_frameNavigated.js and
browser_page_frameNavigated_iframe.js tests make use of the
http://example.com/ test resource server which causes a content
browser remoteness change on navigation. We can work around this
issue and enable the tests by ensuring those test resources are
also loaded using Data URLs, using the helper I introduced in bug
1563533.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1585630: remote: load frameNavigated test resources from Data URL;

In order to get the browser_page_frameNavigated.js and
browser_page_frameNavigated_iframe.js tests passing under Fission
we can load the test resources from the same site origin as the
initial test document. This avoids a content browser remoteness
change, which strictly speaking is not what the tests are testing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3d283afd4d4
remote: load frameNavigated test resources from Data URL; r=remote-protocol-reviewers,whimboo

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/a3d283afd4d4

Comment 4

[Intermittent Failures Robot]

14 failures in 4292 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 14

Platform breakdown:

• linux64: 3
• windows10-64: 3
• windows7-32: 2
• linux64-shippable: 1
• linux64-ccov: 1
• windows10-64-shippable: 1
• windows7-32-shippable: 1
• windows10-64-ccov: 1
• windows10-aarch64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1585630&startday=2019-09-30&endday=2019-10-06&tree=all

Comment 5

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732