1585645 - The context menu of a "Top Sites" tile is not dismissed if the tile is dragged and dropped to a new position

Status: NEW

(Firefox :: New Tab Page, defect)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Beta 70.0b11 - Build ID: 20190930132843
• Firefox Nightly 71.0a1 - Build ID: 20191002033852

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have the latest Firefox Beta or Nightly installed.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Hover any "Top Site" and click the menu button from the top-right part of it.
3. Drag the "Top Site" to any other position and observe the behavior.

[Expected result]:

• The context menu is closed and the "Top Site" is successfully moved to the new position.

[Actual result]:

• The "Top Site" is moved to the new position, but the context menu is not closed.

[Regression Window]

• Considering the fact that this behavior is not reproducible with the latest version of Firefox Release 69.0.1, using the mozregression tool I have managed to find the following regression window:

Last good revision: 0bbd8e64cb9cbef70d12bcf502a8948882b63fe9
First bad revision: 16d1399f602c8a336e8f6e7a160f0e698aff486d
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0bbd8e64cb9cbef70d12bcf502a8948882b63fe9&tochange=16d1399f602c8a336e8f6e7a160f0e698aff486d

From the pushlog, it seems that the regression was caused by bug 1567243.

@Ed, could you please give us your opinion regarding this?

[Notes]:

• Attached a screen recording of the issue.

Comment 1

[Jessilyn Davis]

Marking this as P2 from New Tab POV.

Ed, if you know the fix and want to get it in Nightly 71 this week - go for it!

Comment 2

[Jessilyn Davis]

Removing the Priority so that we talk about this in triage today.

Comment 3

[Pascal Chevrel:pascalc (PTO until Sept 2)]

That bug looks minor, we already shipped this regression, this is unassigned and its priority is unclear. I am marking it as wontfix for 71.

Comment 4

[Jessilyn Davis]

Thank you, Pascal. We're not going to uplift this change into 71. It's a bit edge-case.

We're working through if we can land this in 72 during Nightly of we'll tackle with 73.

Punam - do you know what this is about by chance without digging in too much? If not, Scott will dig in.

Thanks!

Comment 5

[Punam Dahiya [:pdahiya]]

Regression range points to export which has a context menu option fix https://bugzilla.mozilla.org/show_bug.cgi?id=1559383, NI Emily to help verify that the issue reported this bug is not a fallout of 1559383 fix. Thanks!

Comment 6

[Emily McMinn :emcminn]

I'm getting set up today, I'll take a look at this asap. The context menu fix was to add keyboard interaction, but it's possible we interfered with onMenuUpdate in a way that's preventing the menu from closing. That's my best guess!

Comment 7

[Jessilyn Davis]

Thanks for taking a peek Emily! \o/