1585726 - Enable eslint unittests on Windows and Mac in CI

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P1)

Description

[Andrew Halberstadt [:ahal]]

We currently skip them because 'node' doesn't exist on the workers:
https://searchfox.org/mozilla-central/source/tools/lint/test/python.ini#6

But now that node is a toolchain, it should be pretty straightforward to get this dependency added and run the tests. These likely would have caught some Windows Python 3 regressions that recently landed.

Comment 1

[Andrew Halberstadt [:ahal]]

Hey Geoff, there have been some requests coming in for this and seems like it's becoming a higher priority. Would you be able to add it to your queue?

For extra context, the Windows and Mac tests are skipped because we didn't have node on the workers:
https://searchfox.org/mozilla-central/source/tools/lint/test/python.ini#6

But this was before we had node as a toolchain task. So I think now we could make the source-test-python-mozlint task depend on the node toolchain tasks and ensure the dependency is installed that way. I'd vote we switch Linux to using this method while we're at it as well.

Was going to provide you with an example, but turns out the example was written by you:
https://searchfox.org/mozilla-central/source/taskcluster/ci/source-test/file-metadata.yml#55

So guess you know what to do :p.

Comment 2

[Geoff Brown [:gbrown]]

That doesn't sound too hard....will have a look.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: Bug 1585726 - Run mozlint on macosx64 and win64 too; r=

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa1488b8d06d
Run mozlint on macosx64 and win64 too; r=ahal

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/aa1488b8d06d