Remove nsChangeHint_UpdateTextPath.
Categories
(Core :: Layout, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•5 years ago
|
||
The only thing it does is asserting a bit and posting more async work to the
text frame. It seems we can just post all the async work early instead, and
remove the change hint.
This was only introduced to fix bug 779971, where a <textPath> element
references its parent SVG, which is obviously unsound if we allowed to render
it.
What we're doing right now is a bit silly... We're observing the <svg>, so when
we finish reflowing it and store its overflow, we invalidate its rendering
observers, but that invalidates a descendant, which makes no sense.
Fortunately we don't let the element affect its rendering, as it fails this
check:
But we still request reflow of the outer <text>, which is not amazing. We
shouldn't invalidate anything if the textpath doesn't reference a valid element
and that didn't change. This is roughly what the code tried to do when checking
mValid, except we always initialize mValid to true and thus always trigger at
least one bogus reflow call.
|
|
Assignee | |
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=92e76c7aebcbf53274a59bd50bbe3aace15a212e (ignore gtest failures from another patch)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ed2612dfc5c2 Remove nsChangeHint_UpdateTextPath. r=longsonr
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Description
•