Closed Bug 1585892 Opened 6 years ago Closed 3 years ago

Intermittent OSError: Couldn't sign /builds/scriptworker/work/zipefxg2iz8/firefox/lgpllibs.dll

Categories

(Release Engineering :: Release Automation, defect, P5)

Product:
Release Engineering
Component:
Release Automation
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INACTIVE

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, regression)

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=269568923&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/WMm5hEfnRKuAiFzQQgiBAA/runs/0/artifacts/public/logs/live_backing.log

2019-10-03 06:40:11,051 - signingscript.sign - INFO - /builds/scriptworker/work/zipefxg2iz8/firefox/api-ms-win-crt-convert-l1-1-0.dll is already signed
2019-10-03 06:40:26,605 - scriptworker.utils - WARNING - retry_async: call_autograph: too many retries!
2019-10-03 06:40:26,605 - winsign.sign - ERROR - Couldn't re-sign
Traceback (most recent call last):
File "/builds/scriptworker/bin/signingscript", line 11, in <module>
sys.exit(main())
File "/builds/scriptworker/lib/python3.6/site-packages/signingscript/script.py", line 138, in main
async_main, default_config=get_default_config()
File "/builds/scriptworker/lib/python3.6/site-packages/scriptworker/client.py", line 164, in sync_main
loop.run_until_complete(_handle_asyncio_loop(async_main, context))
File "/tools/python3/lib/python3.6/asyncio/base_events.py", line 468, in run_until_complete
return future.result()
File "/builds/scriptworker/lib/python3.6/site-packages/scriptworker/client.py", line 205, in _handle_asyncio_loop
await async_main(context)
File "/builds/scriptworker/lib/python3.6/site-packages/signingscript/script.py", line 74, in async_main
context, os.path.join(work_dir, path), path_dict["formats"]
File "/builds/scriptworker/lib/python3.6/site-packages/signingscript/task.py", line 216, in sign
output = await signing_func(context, output, fmt)
File "/builds/scriptworker/lib/python3.6/site-packages/signingscript/sign.py", line 1445, in sign_authenticode_zip
await asyncio.gather(*tasks)
File "/builds/scriptworker/lib/python3.6/site-packages/signingscript/sign.py", line 1407, in sign_authenticode_file
return await loop.run_in_executor(None, sign_file)
File "/tools/python3/lib/python3.6/concurrent/futures/thread.py", line 56, in run
result = self.fn(*self.args, **self.kwargs)
File "/builds/scriptworker/lib/python3.6/site-packages/signingscript/sign.py", line 1404, in sign_file
raise IOError(f"Couldn't sign {orig_path}")
OSError: Couldn't sign /builds/scriptworker/work/zipefxg2iz8/firefox/lgpllibs.dll
exit code: 1

Hi Aki, should we file a general bug for these https://bugzilla.mozilla.org/buglist.cgi?quicksearch=OSError%20Couldn%27t%20sign&list_id=14923386 or leave them separate?

Flags: needinfo?(aki)

Chris, is this related to your work? I'm guessing we're missing the already-signed check, or have a bug.

  • do we have a fix?
  • are these dups?
Flags: needinfo?(aki) → needinfo?(catlee)

It actually failed when trying to reach autograph, although the log doesn't make that clear.
2019-10-03 06:40:26,605 - scriptworker.utils - WARNING - retry_async: call_autograph: too many retries!

I'll see if I can make the logs clearer in this case.

Flags: needinfo?(catlee)

I landed https://github.com/mozilla-releng/signingscript/commit/7ba0ac2f4a68aebf0c54d03c097164f52e9863c3, which hopefully should give us more information if this happens again.

Intermittent last seen 3 years ago.

Status: NEW → RESOLVED
Closed: 3 years ago
QA Contact: mozilla → jlorenzo
Resolution: --- → INACTIVE
Component: Release Automation: Signing → Release Automation
You need to log in before you can comment on or make changes to this bug.