Closed Bug 1585904 Opened 1 year ago Closed 10 months ago

[Certificate Viewer] The same certificate is opened in different tabs

Categories

(Firefox :: Security, enhancement, P3)

71 Branch
Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
Firefox 73
Tracking Status
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- verified

People

(Reporter: cbaica, Assigned: carolina.jimenez.g)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

[Affected platforms]:

  • win 10
  • macOS 10.14
  • ubuntu 18.04

[Steps to reproduce]:

  1. Launch Firefox.
  2. Navigate to about:preferences#privacy, scroll down to the Certificates section.
  3. Click View Certificates button.
  4. Select the first certificate and click the 'View...' button.
  5. Switch back to the about:preferences tab, and click the 'View...' button again, for the same certificate.

[Expected result]:

  • The user is redirected to the already open tab of that certificate.

[Actual result]:

  • A new about:certificate tab is opened.

[Regression range]:

  • This is not a regression

[Additional notes]:

  • This issue occurs if the about:certificate page is opened from the page information panel of the a website.

Changing to enhancement, as I don't think this situation will come up terribly often.

Type: defect → enhancement
Assignee: nobody → carolina.jimenez.g
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9d1379c65f5
Avoids opening the same certificate in multiple tabs each time.r=johannh,nhnt11
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af28127350c3
Backed out changeset e9d1379c65f5 for browser-chrome failures on browser_pageinfo_security.

I'll take a look asap

Flags: needinfo?(carolina.jimenez.g)

When I run those tests locally they pass (I think they failed just in windows?), I'm not sure what may be wrong with these changes.
Johann, can you give me any insights on how to solve this issues please?

Flags: needinfo?(jhofmann)

The test log shows TypeError: window.switchToTabHavingURI is not a function on viewCert@chrome://browser/content/pageinfo/security.js:42:14, you probably need to use Services.wm.getMostRecentWindow("navigator:browser"); to get the actual browser window (as opposed to the pageinfo window) here as well.

Flags: needinfo?(jhofmann)

Thank you! I got lost on the test log but now I know where to read

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1fc592ffaf4
Avoids opening the same certificate in multiple tabs each time.r=johannh,nhnt11
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Flags: qe-verify+

Reproduced the initial issue using Release version 72.0.1 (Build id: 20200107212822).
Verified - Fixed in latest Nightly build 74.0a1 (Build id: 20200108215606) and latest Beta 73.0b2 (Build id: 20200107212705) using Windows 10, Mac OS 10.14 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.