1585938 - Perma battery-status/battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html | Feature-Policy allow="battery" disallows cross-origin relocation. - frame.allow is undefined when Gecko 71 merges to Beta on 2019-10-14

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Razvan Maries]

[Tracking Requested - why for this release]:

Central as beta:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=269586390&resultStatus=testfailed%2Cbusted%2Cexception&revision=7e2691457a0a60832980608b33e39a6556b9e77c&searchStr=wpt13

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269586390&repo=try&lineNumber=2024

[task 2019-10-03T10:37:04.582Z] 10:37:04 INFO - TEST-START | /battery-status/battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html
[task 2019-10-03T10:37:05.436Z] 10:37:05 INFO -
[task 2019-10-03T10:37:05.436Z] 10:37:05 INFO - TEST-FAIL | /battery-status/battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html | Feature-Policy allow="battery" allows same-origin relocation. - frame.allow is undefined
[task 2019-10-03T10:37:05.436Z] 10:37:05 INFO - test_feature_availability@https://web-platform.test:8443/feature-policy/resources/featurepolicy.js:36:5
[task 2019-10-03T10:37:05.437Z] 10:37:05 INFO - @https://web-platform.test:8443/battery-status/battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html:17:28
[task 2019-10-03T10:37:05.437Z] 10:37:05 INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1908:25
[task 2019-10-03T10:37:05.437Z] 10:37:05 INFO - async_test@https://web-platform.test:8443/resources/testharness.js:576:22
[task 2019-10-03T10:37:05.437Z] 10:37:05 INFO - @https://web-platform.test:8443/battery-status/battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html:16:11
[task 2019-10-03T10:37:05.437Z] 10:37:05 INFO - TEST-UNEXPECTED-FAIL | /battery-status/battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html | Feature-Policy allow="battery" disallows cross-origin relocation. - frame.allow is undefined
[task 2019-10-03T10:37:05.437Z] 10:37:05 INFO - test_feature_availability@https://web-platform.test:8443/feature-policy/resources/featurepolicy.js:36:5
[task 2019-10-03T10:37:05.437Z] 10:37:05 INFO - @https://web-platform.test:8443/battery-status/battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html:23:28
[task 2019-10-03T10:37:05.438Z] 10:37:05 INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:1908:25
[task 2019-10-03T10:37:05.438Z] 10:37:05 INFO - async_test@https://web-platform.test:8443/resources/testharness.js:576:22
[task 2019-10-03T10:37:05.438Z] 10:37:05 INFO - @https://web-platform.test:8443/battery-status/battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html:22:11

James, this seems to be related to bug 1488308. Could you take a look?

Comment 1

[James Graham [:jgraham]]

This seems to be different on beta and nightly; it either needs to be annotated with if release_or_beta or it needs a pref set or similar so the beta behaviour matches nightly. ni Neha for a decision on the best aproach for this case.

Comment 2

[Neha Kochar [:neha]]

Passing the ni to Daosheng to make the call.

Comment 3

[Daosheng Mu[:daoshengmu]]

I will take a look at this next week. Let me keep this ni until I figure it out.

Comment 4

[Intermittent Failures Robot]

1 failures in 4292 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1585938&startday=2019-09-30&endday=2019-10-06&tree=all

Comment 5

[Daosheng Mu[:daoshengmu]]

I think I found the root cause. It is because HTMLIFrameElement.allow is only available when "dom.security.featurePolicy.enabled" is on. [1] "dom.security.featurePolicy.enabled" is only true at Nightly now. [2][3]

[1] https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/dom/webidl/HTMLIFrameElement.webidl#80
[2] https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/dom/security/featurepolicy/FeaturePolicy.h#24
[3] https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/modules/libpref/init/StaticPrefList.yaml#2088

Comment 6

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1585938 - Annotating battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html as a known failure if it is not Nightly build.

Comment 7

[Daosheng Mu[:daoshengmu]]

Try looks good in Nightly, https://treeherder.mozilla.org/#/jobs?repo=try&revision=af0419d0076a22949bcf91260cc8a4bbfeab93a7

Comment 8

[Daosheng Mu[:daoshengmu]]

Please help verify if it is resolved in Beta. I can't verify it because it happens 'mach build -v' did not run successfully in treeherder to me.

Comment 9

[Andreea Pavel [:apavel]]

(In reply to Daosheng Mu[:daoshengmu] from comment #8)

Please help verify if it is resolved in Beta. I can't verify it because it happens 'mach build -v' did not run successfully in treeherder to me.

Verified in recent beta simulations: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=fbc64a86d5ef083dd2e88d999f119e1f9d07f0b0&searchStr=wpt13&selectedJob=270255824 the patch works, please add a reviewer so this can land on integration.

Comment 10

[Daosheng Mu[:daoshengmu]]

(In reply to Andreea Pavel [:apavel] from comment #9)

(In reply to Daosheng Mu[:daoshengmu] from comment #8)

Please help verify if it is resolved in Beta. I can't verify it because it happens 'mach build -v' did not run successfully in treeherder to me.

Verified in recent beta simulations: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=fbc64a86d5ef083dd2e88d999f119e1f9d07f0b0&searchStr=wpt13&selectedJob=270255824 the patch works, please add a reviewer so this can land on integration.

thanks :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/057bb7522a24
Annotating battery-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html as a known failure if it is not Nightly build. r=bzbarsky

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/057bb7522a24

Comment 13

[Andreea Pavel [:apavel]]

No longer occurs in recent beta simulations: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=bb2fcf3fbaadf65542cbd01b7cbb82a93f1a6bba&searchStr=wpt

Comment 14

[Intermittent Failures Robot]

1 failures in 3801 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• windows7-32-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1585938&startday=2019-10-07&endday=2019-10-13&tree=all