Closed Bug 1585957 Opened 6 years ago Closed 6 years ago

Minimal support for mips64r6

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: radovan.birdic, Assigned: radovan.birdic)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

As a part of our internal project of bringing up Debian for mips64r6[1] , we did a port of mozjs60 jit engine. I would like to contribute these changes to the Mozilla community. These changes have been forward ported to the current trunk and are passing our local tests. For time being, we decide to not implement web assembly jit support.

[1] - https://www.mips.com/?do-download=the-mips64-instruction-set-v6-06

Keywords: checkin-needed

Radovan, there's something strange with your patch.
Lando complains about the commit message and phabricator says there's no commit information.

Flags: needinfo?(radovan.birdic)

(In reply to Bogdan Tara[:bogdan_tara] from comment #3)

Radovan, there's something strange with your patch.
Lando complains about the commit message and phabricator says there's no commit information.

I don't know what is right commit procedure. I would like this with the commit message "Minimal support for mips64r6", but I don't have commit rights.
Do I need to do something more on the phabricator side?
Can you provide more guidance?

Flags: needinfo?(radovan.birdic) → needinfo?(btara)

Radovan, thank you for the commit message.

I'll try to import the patch, add the commit message and land the patch.

Flags: needinfo?(btara)

Ok, thank you.

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee: nobody → radovan.birdic
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: