1585993 - Some files have a wrong path in generated sym file because of symlinks in paths when using symstore

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Calixte Denizet (:calixte)]

For example:

• dist/include/mozilla/Components.h is in fact xpcom/components/Components.h which is generated (so we should have a s3 link instead of a hg one).
• dist/include/AllocationPolicy.h is in fact dom/media/platforms/AllocationPolicy.h

Replacing os.path.normpath by os.path.realpath (https://searchfox.org/mozilla-central/source/toolkit/crashreporter/tools/symbolstore.py#301) fixes 1544 paths under linux.

According to the comment for the windows code, it seems that the windows normpath is in fact a realpath.

Comment 1

[Calixte Denizet (:calixte)]

Attachment: Bug 1585993 - Resolve symlinks when generating file paths for breakpad symbol file

Some paths contain symlinks and Python normpath doesn't resolve them.
So it results on having wrong paths in generated breakpad file.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/973cd615817e
Resolve symlinks when generating file paths for breakpad symbol file r=gsvelto

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/973cd615817e