Closed Bug 1585993 Opened 2 years ago Closed 2 years ago

Some files have a wrong path in generated sym file because of symlinks in paths when using symstore

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: calixte, Assigned: calixte)

Details

Attachments

(1 file)

For example:

  • dist/include/mozilla/Components.h is in fact xpcom/components/Components.h which is generated (so we should have a s3 link instead of a hg one).
  • dist/include/AllocationPolicy.h is in fact dom/media/platforms/AllocationPolicy.h

Replacing os.path.normpath by os.path.realpath (https://searchfox.org/mozilla-central/source/toolkit/crashreporter/tools/symbolstore.py#301) fixes 1544 paths under linux.

According to the comment for the windows code, it seems that the windows normpath is in fact a realpath.

Assignee: nobody → cdenizet

Some paths contain symlinks and Python normpath doesn't resolve them.
So it results on having wrong paths in generated breakpad file.

Pushed by cdenizet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/973cd615817e
Resolve symlinks when generating file paths for breakpad symbol file r=gsvelto
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.