1586043 - MOZ_CRASH in MediaKeySystemAccessManager::Request if closing tab/window at wrong time

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

It's possible to hit the MOZ_CRASH here if one closes a Window requesting MediaKeySystemAccess at just the right/wrong time. Easiest way to repro is to rapidly open and close a page that requests MediaKeySystemAccess, though I've only hit it a couple of times and it's taken me 10s of attempts each time.

I noticed this while debugging other EME related issues. We should downgrade this crash to a log as it causes pain when debugging and can conceivably be hit in normal usage.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1586043 - Gracefully handle IPC failure when checking if MediaKeySystemAccess is allowed on Windows. r?dminor

Because it's possible to have the IPC fail when checking if MediaKeySystemAccess
should be allowed, we should gracefully handle the IPC failure case. If we don't
gracefully handle here, closing the tab during requestMediaKeySystemAccess can
result in crashing the content process.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c68cd1024e95da20cc3d22de841c8ac368a77b12&selectedJob=269675328

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c6ea248e4a2
Gracefully handle IPC failure when checking if MediaKeySystemAccess is allowed on Windows. r=dminor

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9c6ea248e4a2

Comment 5

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

Is this issue verifiable manually?
If so, could you please provide QA with STR to verify it?

Thank you in advance!

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Because the issue is racy the STR are not guaranteed to cause the issue. I.e. you can repeat the steps on an affected build and should eventually hit the crash.

You could compare an affected nightly to one after the patch has been applied. If the fixed nightly doesn't fault after enough attempts it would be a positive indicator. However, it's hard to be entirely sure the bug is fixed because of its racy nature.

STR:

• Open Firefox.
• Keep the default tab open so that Firefox doesn't close as we open and close other tabs.
• Rapidly open a tab, navigate to https://shaka-player-demo.appspot.com/, and close the tab. I did this by having the URL on my clipboard and performing ctrl + t, ctrl + v, ctrl + w.

Comment 7

[Alin Ilea, Desktop QA]

Hi,

I didn't manage to reproduce the issue from the description, following the steps from comment 6 on all OS platforms using Fx 71.0a1 (2019-10-03). Are there some extra steps that can help us to reproduce the issue or any settings that must be changed? Or can you please verify that the issue is fixed in the environment which the issue occurred, in the latest Beta 71 build?

Thanks in advance.

Comment 8

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

The issue should be Windows specific, and should be fixed in 71 beta. I don't think any release versions will exhibit the issue -- only certain nightly releases from the 71 cycle will have the problem.