1586062 - WebRender doesn't render when picture caching is disabled

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Dzmitry Malyshau [:kvark]]

The screen is flickering between black and transparent, no surfing is possible.

Comment 1

[Dzmitry Malyshau [:kvark]]

I took a GPU capture, and "pass 7/framebuffer/Composite/" is empty.

Comment 2

[Glenn Watson [:gw]]

Attachment: Bug 1586062 - Fix WebRender with picture caching path disabled.

We need to detect this code path in renderer, and call the
legacy draw_color_target method.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46c1d4bde8d4
Fix WebRender with picture caching path disabled. r=kvark

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/46c1d4bde8d4

Comment 5

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

Could you please provide QA with STR for verifying this ticket ?

Thank you in advance!

Comment 6

[Glenn Watson [:gw]]

Sure - ensure that you have webrender enabled (you can confirm via about:support) and then:

• Set gfx.webrender.picture-caching to false in about:config
• Restart the browser.

If you see anything other than a blank white screen, it's verified :)

Comment 7

[Alexandru Trif, Desktop QA [:atrif]]

Hello! Reproduced the issues using Firefox 71.0a1 (20191003214801) on Windows 10x64 and STR from comment 6.
The issue is verified fixed with firefox 71.0b9 (20191111170815) on Windows 10x64, macOS 10.12 and Ubuntu 18.04. No blank screen presented while using Webrender and setting gfx.webrender.picture-caching to false. Thank you for STR Glenn.