1586090 - Make sign up for breach alert easier from Protection report

Status: VERIFIED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[chsiang]

Current flow:

• click sign up for breach alert button
• lands on https://monitor.firefox.com/?entrypoint=protection_report_monitor
• user follows the instructions to sign up

FxA team has implemented the oauth flow so an existing account users should just go through that flow and be able to sign up with one click

Erica, could you take a look and see how fast we could implement this?

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Assuming this is also meant for 71.

Comment 2

[Vlad Filippov (:vladikoff)]

Is this the flow that the FxA team had in mind for this: https://github.com/mozilla/fxa/pull/1150 ?

Comment 3

[Shane Tomlinson [:stomlinson]]

(In reply to Vlad Filippov (:vladikoff) from comment #2)

Is this the flow that the FxA team had in mind for this: https://github.com/mozilla/fxa/pull/1150 ?

It's a valid use of prompt=none. Note, monitor/the browser will need to handle the errors listed here [1] to ensure a smooth flow.

[1] - https://github.com/mozilla/fxa/blob/master/packages/fxa-auth-server/fxa-oauth-server/docs/prompt-none.md#handling-errors

Comment 4

[Erica Wright [:ewright]]

There has been some confusion around the ask in this bug. It is that if the user is signed in with the browser, they should not land on the landing page on monitor, but instead should see the FXA login screen with their email already populated, then be redirected to monitor after logging in. This currently happens if the user is not subscribed to monitor, but this does not happen correctly if the user is subscribed to monitor.
This is an easy fix - coming up.

Comment 5

[Erica Wright [:ewright]]

Attachment: Bug 1586090 - Direct signed-in and subscribed users to fxa on monitor page.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5287a548f20b
Direct signed-in and subscribed users to fxa on monitor page. r=MattN

Comment 7

[Erica Wright [:ewright]]

Comment on attachment 9101340 [details]
Bug 1586090 - Direct signed-in and subscribed users to fxa on monitor page.

Beta/Release Uplift Approval Request

• User impact if declined: Users who are both signed in and subscribed to monitor need to go through an extra step of arriving on the monitor landing page, and signing in from there. Instead of being directed to the FXA auth page then redirected to their personal monitor report.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small JS change, reusing and moving code, nothing new. This flow has already been implemented if the user is signed in and not subscribed to monitor.
• String changes made/needed: none

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5287a548f20b

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Erica, Johann, does this need to be in 70? It's aimed at the 70.1 dot release, right?

Comment 10

[Erica Wright [:ewright]]

(In reply to Liz Henry (:lizzard) from comment #9)

Erica, Johann, does this need to be in 70? It's aimed at the 70.1 dot release, right?

Yes please, if it can make it into the 70.1 release that would be good.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you suggest some way for QA to verify the fix in beta?

Comment 12

[Erica Wright [:ewright]]

(In reply to Liz Henry (:lizzard) from comment #11)

Can you suggest some way for QA to verify the fix in beta?

Yes!

• Sign in to the browser and sign in to monitor
• Visit the protection report
• After seeing the monitor card load with your login information, follow the link at "View full report on Firefox Monitor"
• the link should lead to account verification at accounts.firefox.com, then redirect to "https://monitor.firefox.com/user/dashboard"

Before this fix

• the link led to "https://monitor.firefox.com/?entrypoint=protection_report_monitor"

Comment 13

[Oana Botisan, Desktop QA]

I verified the fix using latest Nightly 72.0a1 and Firefox 71.0b4 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The issue is not reproducing anymore.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9101340 [details]
Bug 1586090 - Direct signed-in and subscribed users to fxa on monitor page.

Tweak to signin flow, verified in nightly. OK for uplift to m-r for 70.1.

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/21d0e1439be1

Comment 16

[Oana Botisan, Desktop QA]

I verified the fix on Firefox 70.0.1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The issue is not reproducing anymore.

Comment 17

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.