158612 - The CSS parser should only print parser errors _once_

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Roland Mainz]

2002-07-18-08-trunk on Solaris/SPARC.

Problem:
1. Go to http://www.bild.de/
2. The CSS parser starts to spam the console with
-- snip --
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
CSS Error (http://static.bild.de/ticker/live/ticker.html :1.5): Error in parsing
value for property 'left'.  Declaration dropped.
[and so on...]
-- snip --

Suggested fix:
The CSS parser should only print parser errors _once_.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm...  This is an interesting question.... Should we somehow disable error 
reporting for dynamic inline style changes until we have a way of handling this 
gracefully?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd say wontfix.  We could change the console error reporting to be chrome-only,
though.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(By console reporting, I mean the |#ifdef DEBUG| fprintf, not the reporting to
the error console.)

Comment 4

[Roland Mainz]

David Baron wrote:
> I'd say wontfix.

... which means that debug-builds will close to be unuseable in such cases - the
CSS parser error messages consume much CPU time (xterm/dtterm+Xserver) ... ;-(

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So I think the solution to your problem is only to fprintf the warnings to the
console for chrome URIs, or something else that determines whether something is
for chrome or content (although we do want to print for the UA stylesheets). 
However, that's not what the subject of the bug says, and I think the subject of
the bug should be wontfix.

Comment 6

[Roland Mainz]

David Baron wrote:
> So I think the solution to your problem is only to fprintf the warnings to the
> console for chrome URIs, or something else that determines whether something 
> is for chrome or content (although we do want to print for the UA 
> stylesheets). 

What about making this a feature which can be enabled via two pref (one for
chrome, one for content) - and/or replace the |fprintf()| with |PR_LOG()|
statements... ?

Comment 7

[Boris Zbarsky [:bzbarsky]]

We need a solution to this problem in general, though, if we ever plan to enable
CSS error reporting in non-debug builds...  Otherwise the JS console will be
quickly overwhelmed.

Perhaps we should hack something in specifically for inline style?

Comment 8

[Zack Weinberg (:zwol)]

Is this still a meaningful bug?  The error console certainly does get flooded with junk CSS error messages a lot...