1586140 - trim ServoBindings.toml

Status: RESOLVED INCOMPLETE

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Cameron McCormack (:heycam)]

Emilio suggested that we can trim some of things that we bindgen now that we have more things being cbindgened, in the other direction. And he is right! Removing just nsStyleConsts.h saves 12 seconds in my debug build.

Comment 1

[Cameron McCormack (:heycam)]

Actually, my mistake; the 12 seconds was due to some other bindgen patches I had applied locally.

Still, there are a bunch of other things we can remove.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1586140 - Trim ServoBindings.toml.

Comment 3

[Cameron McCormack (:heycam)]

This reduces structs.rs a little but only shows a small runtime improvement in debug builds.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b925e911f646
Trim ServoBindings.toml. r=emilio

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/811757e1e1afb18c9391432e3ead6936332a9499
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269735495&repo=autoland&lineNumber=40951

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:heycam, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Cameron McCormack (:heycam)]

Not getting back to this.