1586195 - Crash in [@ mozilla::net::HttpChannelParent::RecvRedirect2Verify]

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-6a42e4b3-345f-4cd5-b0ee-de0b90191003.

Top 10 frames of crashing thread:

0 xul.dll class mozilla::ipc::IPCResult mozilla::net::HttpChannelParent::RecvRedirect2Verify netwerk/protocol/http/HttpChannelParent.cpp:942
1 xul.dll mozilla::net::PHttpChannelParent::OnMessageReceived ipc/ipdl/PHttpChannelParent.cpp:886
2 xul.dll mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:5873
3 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2109
4 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1985
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
6 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
7 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:88
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290

There are 11 crashes (from 9 installations) in nightly 71 starting with buildid 20191003093956. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1584207.

[1] https://hg.mozilla.org/mozilla-central/rev?node=effee4ab270c

Comment 1

[Honza Bambas (:mayhemer)]

Thanks. Yes, it's a regression from that bug.

Weirdly, mChannel can be null... This is quite unexpected.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: Bug 1586195 - Add a non-null check for mChannel in HttpChannelParent::RecvRedirect2Verify as it can already be legally dropped, r=michal

Comment 3

[Pascal Chevrel:pascalc]

Jan, Michal, the volume of crashes on nightly is significant and we are in soft code freeze period. Can this patch land in nightly this week so as that we can avoid the extra churn of an uplift during the beta cycle? Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55b215923179
Add a non-null check for mChannel in HttpChannelParent::RecvRedirect2Verify as it can already be legally dropped, r=michal

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/55b215923179