Closed Bug 1586195 Opened 2 months ago Closed Last month

Crash in [@ mozilla::net::HttpChannelParent::RecvRedirect2Verify]

Categories

(Core :: Networking, defect, P1, critical)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 + fixed

People

(Reporter: calixte, Assigned: mayhemer)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: crash, regression, Whiteboard: [necko-triaged])

Crash Data

Attachments

(1 file)

This bug is for crash report bp-6a42e4b3-345f-4cd5-b0ee-de0b90191003.

Top 10 frames of crashing thread:

0 xul.dll class mozilla::ipc::IPCResult mozilla::net::HttpChannelParent::RecvRedirect2Verify netwerk/protocol/http/HttpChannelParent.cpp:942
1 xul.dll mozilla::net::PHttpChannelParent::OnMessageReceived ipc/ipdl/PHttpChannelParent.cpp:886
2 xul.dll mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:5873
3 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2109
4 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1985
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
6 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
7 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:88
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290

There are 11 crashes (from 9 installations) in nightly 71 starting with buildid 20191003093956. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1584207.

[1] https://hg.mozilla.org/mozilla-central/rev?node=effee4ab270c

Flags: needinfo?(honzab.moz)

Thanks. Yes, it's a regression from that bug.

Weirdly, mChannel can be null... This is quite unexpected.

Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Flags: needinfo?(honzab.moz)
Priority: -- → P1
Whiteboard: [necko-triaged]

Jan, Michal, the volume of crashes on nightly is significant and we are in soft code freeze period. Can this patch land in nightly this week so as that we can avoid the extra churn of an uplift during the beta cycle? Thanks.

Flags: needinfo?(odvarko)
Flags: needinfo?(michal.novotny)
Flags: needinfo?(odvarko)
Flags: needinfo?(michal.novotny)
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55b215923179
Add a non-null check for mChannel in HttpChannelParent::RecvRedirect2Verify as it can already be legally dropped, r=michal

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.