1586246 - Migrate autohide-context to Fluent using convert script

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

I wrote an updated version of the conversion script and want to test it on a simple conversion: https://searchfox.org/mozilla-central/rev/01d1011ca4a460f751da030d455d35c267c3e210/browser/base/content/browser.xhtml#485-494

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1586246 - Migrate autohide-context to Fluent using convert script.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

I was able to generate this patch using https://github.com/zbraniecki/convert_xul_to_fluent with the following call:

python3 convert.py --bug_id 1586246 --description "Convert autohide-context to Fluent" --mc ~/projects/mozilla-unified/ --dom ./browser/base/content/browser.xhtml:485:494 --dtd ./browser/locales/en-US/chrome/browser/browser.dtd --ftl ./browser/locales/en-US/browser/browser.ftl

the script is very simple for now (no replacements, no handling for placeholders, values etc.), but adding features should be easy.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

I tried to test the migration using:

./mach fluent-migration-test python/l10n/fluent_migrations/bug_1586246_migration.py

but got the following error:

Zibis-MacBook-Pro:mozilla-unified (convert-1)$ ./mach fluent-migration-test python/l10n/fluent_migrations/bug_1586246_migration.py
 0:00.85 hg pull -u
 0:05.41 /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/_virtualenvs/init/bin/python -m fluent.migrate.tool --lang en-US --reference-dir /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/reference --localization-dir /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/en-US --dry-run fluent_migrations.bug_1586246_migration

Running migration fluent_migrations.bug_1586246_migration for en-US
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/local/Cellar/python@2/2.7.16_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/Users/zbraniecki/projects/mozilla-unified/third_party/python/fluent/fluent/migrate/tool.py", line 184, in <module>
    cli()
  File "/Users/zbraniecki/projects/mozilla-unified/third_party/python/fluent/fluent/migrate/tool.py", line 179, in cli
    dry_run=args.dry_run
  File "/Users/zbraniecki/projects/mozilla-unified/third_party/python/fluent/fluent/migrate/tool.py", line 133, in main
    migrator.run(migration)
  File "/Users/zbraniecki/projects/mozilla-unified/third_party/python/fluent/fluent/migrate/tool.py", line 70, in run
    blame = Blame(self.client).attribution(files)
  File "/Users/zbraniecki/projects/mozilla-unified/third_party/python/fluent/fluent/migrate/blame.py", line 26, in attribution
    blame_json = self.client.rawcommand(args)
  File "/Users/zbraniecki/projects/mozilla-unified/third_party/python/python-hglib/hglib/client.py", line 246, in rawcommand
    raise error.CommandError(args, ret, out, err)
hglib.error.CommandError: (255, '', 'abort: at least one filename or pattern is required')
Error running mach:

    ['fluent-migration-test', 'python/l10n/fluent_migrations/bug_1586246_migration.py']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Process executed with non-0 exit code 1: [u'/Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/_virtualenvs/init/bin/python', '-m', 'fluent.migrate.tool', '--lang', 'en-US', '--reference-dir', u'/Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/reference', '--localization-dir', u'/Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/en-US', '--dry-run', 'fluent_migrations.bug_1586246_migration']

  File "/Users/zbraniecki/projects/mozilla-unified/testing/mach_commands.py", line 1427, in run_migration_tests
    rv |= fmt.test_migration(self, obj_dir, **context)
  File "/Users/zbraniecki/projects/mozilla-unified/python/l10n/test_fluent_migrations/fmt.py", line 110, in test_migration
    line_handler=print,
  File "/Users/zbraniecki/projects/mozilla-unified/python/mach/mach/mixin/process.py", line 148, in run_process
    raise Exception('Process executed with non-0 exit code %d: %s' % (status, args))

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Flod - can you help me figure out the migration? Is it a good one? Why can't I test it? Did I miss something?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

:flod helped me on slack and I updated the patch and the script!

Now the output of the test is:

Zibis-MBP:mozilla-unified (convert-1)$ ./mach fluent-migration-test python/l10n/fluent_migrations/bug_1586246_migration.py
 0:00.52 hg pull -u
 0:04.46 /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/_virtualenvs/init/bin/python -m fluent.migrate.tool --lang en-US --reference-dir /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/reference --localization-dir /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/en-US --dry-run fluent_migrations.bug_1586246_migration

Running migration fluent_migrations.bug_1586246_migration for en-US
  Writing to /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/en-US/browser/browser/browser.ftl
  Committing changeset: Bug 1586246 - Convert autohide-context to Fluent, part 1
 0:05.60 /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/_virtualenvs/init/bin/python -m fluent.migrate.tool --lang en-US --reference-dir /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/reference --localization-dir /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/en-US fluent_migrations.bug_1586246_migration

Running migration fluent_migrations.bug_1586246_migration for en-US
  Writing to /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/en-US/browser/browser/browser.ftl
  Committing changeset: Bug 1586246 - Convert autohide-context to Fluent, part 1
    WARNING: hg commit failed ((1, 'committing files:\nbrowser/browser/browser.ftl\ncommitting manifest\ncommitting changelog\nupdating the branch cache\nnothing changed', ''))
 0:07.16 diff -u -B /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/reference/browser/browser/browser.ftl /Users/zbraniecki/projects/mozilla-unified/obj-x86_64-apple-darwin18.7.0-opt/python/l10n/bug_1586246_migration/en-US/browser/browser/browser.ftl

Comment 6

[Francesco Lodolo [:flod]]

I think that's an error that someone else was getting (mstriemer), but pike nor I were able to reproduce locally.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6c4ca4c944f
Migrate autohide-context to Fluent using convert script. r=fluent-reviewers,bgrins,flod

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd5d1817233b
Fix linting on bug_1586246_migration.py. CLOSED TREE

Comment 9

[Narcis Beleuzu [:NarcisB]]

Lint log failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269791670&repo=autoland&lineNumber=255

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c6c4ca4c944f
https://hg.mozilla.org/mozilla-central/rev/fd5d1817233b