Closed Bug 1586371 Opened 6 months ago Closed 6 months ago

remove grid usage from comm/calendar/resources/content/calendarCreation.xul

Categories

(Calendar :: Calendar Views, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: khushil324, Assigned: khushil324)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → khushil324

Apply after patch from Bug 1568660.

Attachment #9099045 - Flags: feedback?(mkmelin+mozilla)
Depends on: 1568660
Status: NEW → ASSIGNED
Attachment #9099045 - Flags: review?(paul)
Comment on attachment 9099045 [details] [diff] [review]
Bug-1586371_remove-grid-calendarCreation-1.patch

Review of attachment 9099045 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  To fix in the heading:

Create a new calendar
    Locate your calendar    <-- This line is indented relative to the first line, but shouldn't be indented, 
                                                  they should both be right-aligned.
Attachment #9099045 - Flags: review?(paul)

After I chatted briefly with Khushil about this, I took a closer look. The indentation is from the default <wizard> styles, which appear to have changed. The indented line is part of the wizard's shadow-root. So something like the following in calendar-creation-wizard.css should work:

wizard::shadow .wizard-header-description {
  margin-inline-start: 23px !important;
}

But it did not work for me for some reason. So in the interest of not going too far out of our way to override default styling, I'd say let's just embrace the indented style and maybe revisit in a follow-up effort later if we're so inclined. With the shift from XUL to HTML this will likely all get reshuffled to some extent anyway.

Attachment #9099045 - Flags: review+
Keywords: checkin-needed
Target Milestone: --- → 71

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/69a2aa5bd636
remove grid usage from calendarCreation.xul. r=pmorris DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

This broke calendar/test/browser/browser_localICS.js, and (indirectly, I think) calendar/test/browser/browser_todayPane.js. It wasn't picked up by the Try run because the Try run didn't actually do the calendar UI tests. Backed out:

https://hg.mozilla.org/comm-central/rev/0393c0d6beda736f7cc0cf340af099d8502bbc99

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

comm/calendar/test/browser/browser_todayPane.js
comm/calendar/test/browser/browser_localICS.js
This two mochitests failed previously. Magnus, Can you confirm that these tests pass now?

Attachment #9099045 - Attachment is obsolete: true
Attachment #9099045 - Flags: feedback?(mkmelin+mozilla)
Attachment #9100852 - Flags: review?(mkmelin+mozilla)

./mach test comm/calendar/test/browser/browser_localICS.js
./mach test comm/calendar/test/browser/browser_todayPane.js

Both succeed with the patch.

Attachment #9100852 - Flags: review?(mkmelin+mozilla) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fd44a1cc026d
remove grid usage from calendarCreation.xul. r=pmorris,mkmelin

Status: REOPENED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED

The overlay directives for the two overlay files that were deleted/inlined in this bug weren't removed along with the files. I'm removing them over here: https://bugzilla.mozilla.org/show_bug.cgi?id=1508119#c31

You need to log in before you can comment on or make changes to this bug.