Closed Bug 1586417 Opened Last month Closed Last month

[wpt-sync] Sync PR 19528 - css-flexbox: fixes for -webkit-box using LayoutFlexibleBox

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19528 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19528
Details from upstream follow.

Scott Violet <sky@chromium.org> wrote:

css-flexbox: fixes for -webkit-box using LayoutFlexibleBox

This addresses two problems that triggered CHECKs/use-after-free:

LayoutBlock, for -webkit-box, needs to add children to anonymous
blocks in some cases.

LayoutFlexibleBox should not merge anonymous flex items for
-webkit-box.

BUG=1010706
TEST=none

Change-Id: Ic8cb22f4f031813c1e1447bc23f4bfb930b3caec
Reviewed-on: https://chromium-review.googlesource.com/1838754
WPT-Export-Revision: 1111af4d783121763fddc878ee618d8c192bea95

Component: web-platform-tests → Layout
Product: Testing → Core
## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=4e536899cc8235f40b9909f318f0fed33d687ae4&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=4e536899cc8235f40b9909f318f0fed33d687ae4&label=pr_base)

Ran 1 tests and 1 subtests

### Firefox
  OK  : 1
  PASS: 1

### Chrome
  OK  : 1
  PASS: 1

### Safari
  OK  : 1
  PASS: 1

## Gecko CI Results

Ran 1 tests and 1 subtests
  OK     : 1
  PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a504da511737
[wpt PR 19528] - css-flexbox: fixes for -webkit-box using LayoutFlexibleBox, a=testonly
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.