1586427 - `moz_bookmarks.type` can be null, causing bookmark merges to fail

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P3)

Description

[Lina Butler (ex-Mozilla)]

One of the errors that show up in telemetry for 71 is:

MergeError: Can't get i64 for column type

There's only one place we do that, and, looking at the Places schema, type doesn't have a NOT NULL constraint! 😳

We have Places maintenance tasks for fixing wrong item types, but not if the type is NULL. I think we could add one, let the sync fail, and have maintenance fix up the DB.

Comment 1

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1586427 - Expand Places maintenance tasks for missing and wrong item types. r?mak!

This commit updates maintenance to change an item's GUID when changing
its type, and adds a task to insert tombstones for the old GUIDs. This
ensures that the item is synced correctly to other clients, without
throwing errors or creating duplicates. We'll still need to handle
existing items on the server; that's bug 1586434.

This commit also adds a new task to fix up NULL types, and moves
the task to remove items referencing nonexistent Place IDs after
the new task. This ensures we do the right thing for items without
a type, and with an fk that doesn't reference moz_places.id.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff067ec254cd
Expand Places maintenance tasks for missing and wrong item types. r=mak

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ff067ec254cd