Closed
Bug 1586436
Opened 6 years ago
Closed 6 years ago
mscom methods accepting variadic arguments should use rvalue references in their arguments
Categories
(Core :: IPC: MSCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
Details
Attachments
(1 file)
s/Args.../Args&&.../
|
Assignee | |
Updated•6 years ago
|
Summary: mscom::AsyncInvoker::Invoke should use rvalue references in its argument list → mscom methods accepting variadic arguments should use rvalue references in their arguments
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/752704186808
Ensure that mscom methods that accept variadic arguments use rvalue references in their arguments; r=Jamie
|
||
Comment 3•6 years ago
|
||
Backed out for build bustages.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270237690&repo=autoland&lineNumber=76437
Backout: https://hg.mozilla.org/integration/autoland/rev/1cc0ab02fc45c8fea6ce8677d783703814e031e6
Flags: needinfo?(aklotz)
|
|
||
Comment 4•6 years ago
|
||
Another fail caused by this push: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C2012%2Cx64%2Cdebug%2Cbuild-win64-plain%2Fdebug%2C%28bp%29&selectedJob=270238611
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270238611&repo=autoland&lineNumber=35152
|
|
Assignee | |
Comment 5•6 years ago
|
||
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6399f9a20324
Ensure that mscom methods that accept variadic arguments use rvalue references in their arguments; r=Jamie
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•