Closed Bug 1586446 Opened 6 years ago Closed 6 years ago

Ignore duplicate outgoing tags

Categories

(Firefox :: Sync, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: lina, Assigned: lina)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

MergeError: Failed to execute SQL string with code 19 (UNIQUE constraint failed: tagsToUpload.id, tagsToUpload.tag)

I think this can happen if we have duplicate tag entries for the same tag. Under the hood, the tags root structure would look like this:

- tags________
| - tag
| | - http://example.com/a
| | - http://example.com/b
| | - http://example.com/a

...Which "shouldn't" happen, but harmless if it does. I think all we need to do is change this line to INSERT OR IGNORE.

Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4479a9504d0 Ignore duplicate outgoing tags in the bookmarks mirror. r=markh
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: